[GitHub] [skywalking] tom-pytel edited a comment on issue #6100: [NodeJS] Agent getting error in 0.1.0 release that wasn't there before release

[GitBox <gi...@apache.org>]

tom-pytel edited a comment on issue #6100:
URL: https://github.com/apache/skywalking/issues/6100#issuecomment-752647905


   > The protocol sub module is pinned to an old version (https://github.com/apache/skywalking-data-collect-protocol/tree/24788cf41807048dcbe8dba0958688aaaf630d73), while the error is only possible in recent version, make sure you didn't update it locally
   
   Yes I did update the protocol submodule so that is obviously the cause, my bad, went back to the pinned commit and all works fine. Though I updated because I was getting another error which was not present pre-release:
   ```js
   {
     file: '/home/tom/src/revdebugjs/skywalking-nodejs/lib/agent/protocol/grpc/clients/TraceReportClient.js',
     code: 14,
     metadata: Metadata { _internal_repr: {}, flags: 0 },
     details: 'DNS resolution failed',
     level: 'error',
     message: 'Failed to report trace data14 UNAVAILABLE: DNS resolution failed',
     stack: 'Error: 14 UNAVAILABLE: DNS resolution failed\n' +
       '    at Object.exports.createStatusError (/home/tom/src/revdebugjs/skywalking-nodejs/node_modules/grpc/src/common.js:91:15)\n' +
       '    at Object.onReceiveStatus (/home/tom/src/revdebugjs/skywalking-nodejs/node_modules/grpc/src/client_interceptors.js:1238:28)\n' +
       '    at InterceptingListener._callNext (/home/tom/src/revdebugjs/skywalking-nodejs/node_modules/grpc/src/client_interceptors.js:568:42)\n' +
       '    at InterceptingListener.onReceiveStatus (/home/tom/src/revdebugjs/skywalking-nodejs/node_modules/grpc/src/client_interceptors.js:618:8)\n' +
       '    at /home/tom/src/revdebugjs/skywalking-nodejs/node_modules/grpc/src/client_interceptors.js:925:18\n' +
       '    at callbackTrampoline (internal/async_hooks.js:126:14)'
   }
   ```
   This was odd and I traced it down to the agent init code:
   ```js
   agent.start({
     serviceName: '',
     serviceInstance: '',
     collectorAddress: '',
     authorization: '',
     maxBufferSize: 1000,
   });
   ```
   Having the `collectorAddress` as an empty string causes this. This worked fine before release but does not now, which is odd and I am not quite sure how it worked before. But it does not now and the current README specifies this as the proper way to initialize.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org