You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "JeffBolle (via GitHub)" <gi...@apache.org> on 2023/06/20 14:06:51 UTC

[GitHub] [pulsar] JeffBolle opened a new issue, #20619: ElasticSearch Sink Improvements

JeffBolle opened a new issue, #20619:
URL: https://github.com/apache/pulsar/issues/20619

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   The current ElasticSearch sink does not work cleanly with the changes made to allow for Sink pre-processing functions, from PIP 193. Additionally, as mentioned in another [issue](https://github.com/apache/pulsar/issues/13173), the option to use the key from the record should not be tied to whether the schema is enabled or not.
   
   These changes allow the sink to handle `Record<String>` and `Record<byte[]>` which are likely to be output from some pre-processing transform functions.  As long as the record contains a string or bytes that can be parsed as valid JSON, it should be used.  
   
   This comes from a thread on slack with @eolivelli and @cbornet 
   
   ### Solution
   
   modifiy method: `public Pair<String, String> extractIdAndDocument(Record<GenericObject> record) throws JsonProcessingException` to handle cases where the `Record` is `String` or `byte[]`.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari closed issue #20619: ElasticSearch Sink Improvements

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed issue #20619: ElasticSearch Sink Improvements
URL: https://github.com/apache/pulsar/issues/20619


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org