[GitHub] [solr] HoustonPutman commented on a diff in pull request #585: SOLR-15955: Update Jetty dependency to 10

[GitBox <gi...@apache.org>]

HoustonPutman commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1013339786


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -278,6 +295,10 @@ public void close() {
     assert ObjectReleaseTracker.release(this);
   }
 
+  public void setAuthenticationStore(AuthenticationStore authenticationStore) {
+    this.authenticationStore.updateAuthenticationStore(authenticationStore);

Review Comment:
   Why do we have an authenticationStoreHolder instead of just updating the `httpClients` authenticationStore here?



##########
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##########
@@ -76,8 +76,13 @@ public static void processParams(
       String[] jsonFromParams = map.remove(JSON);
 
       for (ContentStream cs : req.getContentStreams()) {
+        // if BinaryResponseParser.BINARY_CONTENT_TYPE, let the following fail below - we may have
+        // adjusted the content without updating the content type
+        // problem in this case happens in a few tests, one seems to happen with kerberos and remote
+        // node query (HttpSolrCall's request proxy)
+
         String contentType = cs.getContentType();
-        if (contentType == null || !contentType.contains("/json")) {
+        if (contentType == null || (!contentType.contains("/json"))) {

Review Comment:
   reason for adding extra parentheses here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org