You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/08 21:59:59 UTC
Review Request 64468: SLRP reconciliation only preserves missing
resources that are converted.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64468/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
When SLRP's checkpointed total resources is inconsistent with CSI
plugin's reported resources, we still want to keep the missing resources
that have been converted through an offer operation before, such that
we can have an consistent view with the frameworks consuming the
resource offers. It is safe to remove unconverted missing resources from
SLRP's checkpointed total.
Diffs
-----
src/resource_provider/storage/provider.cpp 2193866e83850a04a3dc8231ab07e6104485f2b6
Diff: https://reviews.apache.org/r/64468/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64468: SLRP reconciliation only preserves missing
resources that are converted.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64468/#review193310
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 9:59 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64468/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 9:59 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When SLRP's checkpointed total resources is inconsistent with CSI
> plugin's reported resources, we still want to keep the missing resources
> that have been converted through an offer operation before, such that
> we can have an consistent view with the frameworks consuming the
> resource offers. It is safe to remove unconverted missing resources from
> SLRP's checkpointed total.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 2193866e83850a04a3dc8231ab07e6104485f2b6
>
>
> Diff: https://reviews.apache.org/r/64468/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>