You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 23:18:05 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12868: Refactor `@provide_session` to do less "at runtime"

kaxil commented on a change in pull request #12868:
URL: https://github.com/apache/airflow/pull/12868#discussion_r537147365



##########
File path: airflow/utils/session.py
##########
@@ -46,20 +46,23 @@ def provide_session(func: Callable[..., RT]) -> Callable[..., RT]:
     database transaction, you pass it to the function, if not this wrapper
     will create one and close it for you.
     """
+    func_params = func.__code__.co_varnames

Review comment:
       Won't this be still called everytime `provide_session` decorator is called?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org