You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2008/03/22 16:27:48 UTC
svn commit: r640007 - in
/james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager:
mailbox/ImapMailbox.java repository/MailboxManagerMailRepository.java
Author: rdonkin
Date: Sat Mar 22 08:27:47 2008
New Revision: 640007
URL: http://svn.apache.org/viewvc?rev=640007&view=rev
Log:
Added a few TODOs
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/mailbox/ImapMailbox.java
james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/repository/MailboxManagerMailRepository.java
Modified: james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/mailbox/ImapMailbox.java
URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/mailbox/ImapMailbox.java?rev=640007&r1=640006&r2=640007&view=diff
==============================================================================
--- james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/mailbox/ImapMailbox.java (original)
+++ james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/mailbox/ImapMailbox.java Sat Mar 22 08:27:47 2008
@@ -151,7 +151,7 @@
FetchGroup fetchGroup, MailboxSession mailboxSession) throws MailboxManagerException;
/**
- *
+ * TODO: consolidate search and getMessages into a single method
* @param set
* @param mailboxSession TODO
* @return MessageResult with the fields defined by <b>result</b>
@@ -166,5 +166,11 @@
Iterator getMessages(GeneralMessageSet set, FetchGroup fetchGroup, MailboxSession mailboxSession)
throws MailboxManagerException;
+ /**
+ * TODO: this is only used by MailboxManagerMailRepository; Consider deleting;
+ * @param set
+ * @param mailboxSession
+ * @throws MailboxManagerException
+ */
void remove(GeneralMessageSet set, MailboxSession mailboxSession) throws MailboxManagerException;
}
Modified: james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/repository/MailboxManagerMailRepository.java
URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/repository/MailboxManagerMailRepository.java?rev=640007&r1=640006&r2=640007&view=diff
==============================================================================
--- james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/repository/MailboxManagerMailRepository.java (original)
+++ james/server/trunk/core-library/src/main/java/org/apache/james/mailboxmanager/repository/MailboxManagerMailRepository.java Sat Mar 22 08:27:47 2008
@@ -48,6 +48,7 @@
* This implementation should be considered as EXPERIMENTAL.
*
* TODO examine for thread-safety
+ * TODO: consider deleting this implementation; may be better for the wrapping to work the other way;
*/
public class MailboxManagerMailRepository extends AbstractMailRepository
implements Configurable, Serviceable {
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org