[PATCH] svnlook: no more reporting extra newline in log message

[Kristis Makris <mk...@gmx.net>]

I am using svn 1.0.0 to run:

$ svnlook info -r 5 /tmp/tempsv

If I commit a file in r5 with no log message, the output of the above
is:

[----------cut----------------]
mkgnu
2004-08-17 21:51:56 -0700 (Tue, 17 Aug 2004)
0

[----------cut----------------]


There seems to be an extra newline reported be svnlook info. This causes
integration hooks to assume an extra newline is part of the log message,
while this is not the case. I'm assuming the attached patch fixes this,
but did not test.

Would removing the extra newline be the right thing to do ?

Re: [PATCH] svnlook: no more reporting extra newline in log message

["C. Michael Pilato" <cm...@collab.net>]

Kristis Makris <mk...@gmx.net> writes:

> There seems to be an extra newline reported be svnlook info. This causes
> integration hooks to assume an extra newline is part of the log message,
> while this is not the case. I'm assuming the attached patch fixes this,
> but did not test.
> 
> Would removing the extra newline be the right thing to do ?

No.  The right thing to do would be the integration hooks to
actually pay attention to the 0 printed on line three, note that the
log message has 0 bytes, read zero bytes, and call it a day.

Alternatively, you can have your integration hooks *always* remove the
last \n from the log message, because svnlook *always* adds it (for
readability).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org