You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/18 14:57:55 UTC

[GitHub] [spark] srowen commented on a diff in pull request #37919: [SPARK-40478][DOCS] Add create datasource table options docs

srowen commented on code in PR #37919:
URL: https://github.com/apache/spark/pull/37919#discussion_r973733759


##########
docs/sql-ref-syntax-ddl-create-table-datasource.md:
##########
@@ -117,6 +121,15 @@ CREATE TABLE student_copy USING CSV
 --Omit the USING clause, which uses the default data source (parquet by default)
 CREATE TABLE student (id INT, name STRING, age INT);
 
+--Use parquet data source with parquet storage options
+--The columns 'id' and 'name' enable the bloom filter during writing parquet file,
+--column 'age' does not enable
+CREATE TABLE student_parquet(id INT, name STRING, age INT) USING PARQUET
+    OPTIONS (
+      'parquet.bloom.filter.enabled'='true',

Review Comment:
   Other examples of OPTIONS seem different, and would look more like:
   `parquet.bloom.filter.enabled "true",`
   It seems. Is this right and/or should we standardize?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org