You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/21 04:39:49 UTC
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2275: Better Java class wizard
JaroslavTulach commented on a change in pull request #2275:
URL: https://github.com/apache/netbeans/pull/2275#discussion_r491790374
##########
File path: java/java.project.ui/src/org/netbeans/modules/java/project/ui/NewJavaFileWizardIterator.java
##########
@@ -310,7 +314,12 @@ private void addRequires(FileObject createdFile, Set<String> requiredModuleNames
createdFile = dobj.getPrimaryFile();
} else {
DataObject dTemplate = DataObject.find( template );
- DataObject dobj = dTemplate.createFromTemplate( df, targetName );
+ String superclass = (String) wiz.getProperty(SUPERCLASS);
+ String interfaces = (String) wiz.getProperty(INTERFACES);
+ Map<String, String> parameters = new HashMap<>();
+ parameters.put(SUPERCLASS, superclass);
Review comment:
This is a change of API and should be documented as such (incremement module version, enhance `arch.xml`, note in `apichanges.xml`).
##########
File path: java/java.project.ui/src/org/netbeans/modules/java/project/ui/NewJavaFileWizardIterator.java
##########
@@ -310,7 +314,12 @@ private void addRequires(FileObject createdFile, Set<String> requiredModuleNames
createdFile = dobj.getPrimaryFile();
} else {
DataObject dTemplate = DataObject.find( template );
- DataObject dobj = dTemplate.createFromTemplate( df, targetName );
+ String superclass = (String) wiz.getProperty(SUPERCLASS);
+ String interfaces = (String) wiz.getProperty(INTERFACES);
+ Map<String, String> parameters = new HashMap<>();
+ parameters.put(SUPERCLASS, superclass);
Review comment:
This is a change of API and should be documented as such (increment module version, enhance `arch.xml`, note in `apichanges.xml`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists