You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/16 20:17:01 UTC

[GitHub] [pulsar] dave2wave commented on a diff in pull request #16623: rename pulsar env variables for pulsar tools

dave2wave commented on code in PR #16623:
URL: https://github.com/apache/pulsar/pull/16623#discussion_r922716979


##########
conf/pulsar_tools_env.sh:
##########
@@ -42,13 +42,13 @@
 # PULSAR_GLOBAL_ZK_CONF=
 
 # Extra options to be passed to the jvm
-PULSAR_MEM=${PULSAR_MEM:-"-Xmx128m -XX:MaxDirectMemorySize=128m"}
+PULSAR_TOOL_MEM=${PULSAR_MEM:-"-Xmx128m -XX:MaxDirectMemorySize=128m"}

Review Comment:
   1. This will set PULSAR_TOOL_MEM to PULSAR_MEM. It will ignore PULSAR_TOOL_MEM if it is set in the environment.
   2. In a proper override you do need to consider that legacy users will be surprised by this behavior so if PULSAR_TOOL_MEM is not set then check PULSAR_MEM
   
   This same comment applies to PULSAR_TOOL_GC



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org