[GitHub] [lucene-solr] dsmiley commented on pull request #2159: SOLR-14923: Nested docs indexing performance.

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#issuecomment-754901726


   I believe everything MUSE_DEV reported is a non-issue.  Only one thread touches any AddUpdateCommand and the SolrInputDoc on it.  Perhaps MUSE_DEV saw the `synchronized` keyword inside UpdateLog.add and thought otherwise.  But that thing is synchronizing on UpdateLog itself, not the command.
   
   I included SOLR-15069 (parentFilter on [child] is now not needed) inside here, but that should get merged first, and thus it won't show up ultimately for this issue.  SOLR-15069 allows us to safely (no loss of data) do atomic/partial updates when there is no nest path field declared.
   
   @ctargett perhaps you might look over the ref guide changes in here?  I did some editing to reduce the use of the word "block" in favor of the word "nest", and also did some other clarifications.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org