You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/03/14 02:40:29 UTC

[GitHub] [pulsar] coderzc opened a new pull request, #19801: [fix][broker][PIP-195] Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect

coderzc opened a new pull request, #19801:
URL: https://github.com/apache/pulsar/pull/19801

   PIP: #16763  
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
   
   ### Motivation
   
   In #14740, we clean the delayed message tracker when all consumer disconnect to avoid adding duplicated messages,
   but BucketDelayedDeliveryTracker uses bitmap to avoid adding duplicated messages. So we don't clean up BucketDelayedDeliveryTracker, otherwise we will lose the bucket snapshot.
   
   ### Modifications
   
   * Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect
   * Clear missing lastMutableBucketQueue when clear lastMutableBucket
   * Improve logs
   * Add test
   
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #19801: [fix][broker][PIP-195] Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on PR #19801:
URL: https://github.com/apache/pulsar/pull/19801#issuecomment-1467495930

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc merged pull request #19801: [fix][broker][PIP-195] Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc merged PR #19801:
URL: https://github.com/apache/pulsar/pull/19801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc closed pull request #19801: [fix][broker][PIP-195] Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc closed pull request #19801: [fix][broker][PIP-195] Don't clean up BucketDelayedDeliveryTracker when all consumer disconnect
URL: https://github.com/apache/pulsar/pull/19801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org