You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/22 12:21:48 UTC
[GitHub] [doris] Yulei-Yang opened a new pull request, #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Yulei-Yang opened a new pull request, #15297:
URL: https://github.com/apache/doris/pull/15297
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15297:
URL: https://github.com/apache/doris/pull/15297#issuecomment-1362951790
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.87 seconds
load time: 651 seconds
storage size: 17122858586 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221222150901_clickbench_pr_67451.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15297:
URL: https://github.com/apache/doris/pull/15297#discussion_r1056755676
##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -319,12 +319,9 @@ protected TScanRangeLocations newLocations(TBrokerScanRangeParams params, Broker
brokerScanRange.setParams(params);
if (brokerDesc.getStorageType() == StorageBackend.StorageType.BROKER
|| brokerDesc.getStorageType() == StorageBackend.StorageType.OFS) {
- FsBroker broker = null;
- try {
- broker = Env.getCurrentEnv().getBrokerMgr()
- .getBroker(brokerDesc.getName(), selectedBackend.getHost());
- } catch (AnalysisException e) {
- throw new UserException(e.getMessage());
+ FsBroker broker = Env.getCurrentEnv().getBrokerMgr().getAnyAliveBroker();
Review Comment:
Why discard the `selectedBackend` attribute?
It is useful for multi load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
Yulei-Yang commented on PR #15297:
URL: https://github.com/apache/doris/pull/15297#issuecomment-1364525138
@morningman please review, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15297:
URL: https://github.com/apache/doris/pull/15297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15297:
URL: https://github.com/apache/doris/pull/15297#issuecomment-1364610208
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15297:
URL: https://github.com/apache/doris/pull/15297#issuecomment-1364610212
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on a diff in pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
Yulei-Yang commented on code in PR #15297:
URL: https://github.com/apache/doris/pull/15297#discussion_r1056840894
##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -319,12 +319,9 @@ protected TScanRangeLocations newLocations(TBrokerScanRangeParams params, Broker
brokerScanRange.setParams(params);
if (brokerDesc.getStorageType() == StorageBackend.StorageType.BROKER
|| brokerDesc.getStorageType() == StorageBackend.StorageType.OFS) {
- FsBroker broker = null;
- try {
- broker = Env.getCurrentEnv().getBrokerMgr()
- .getBroker(brokerDesc.getName(), selectedBackend.getHost());
- } catch (AnalysisException e) {
- throw new UserException(e.getMessage());
+ FsBroker broker = Env.getCurrentEnv().getBrokerMgr().getAnyAliveBroker();
Review Comment:
oh, my fault, I'm careless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15297: [Improvement](multi-catalog) support hive external tables which store data on tencent chdfs
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15297:
URL: https://github.com/apache/doris/pull/15297#discussion_r1055472847
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java:
##########
@@ -128,6 +128,22 @@ public FsBroker getAnyBroker(String brokerName) {
}
}
+ public FsBroker getAnyAliveBroker() {
+ lock.lock();
+ try {
+ for (List<FsBroker> list : brokerListMap.values()) {
+ for (FsBroker fsBroker : list) {
+ if (fsBroker.isAlive) {
+ return fsBroker;
Review Comment:
you will always get the first broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org