You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2024/02/02 06:53:57 UTC

[PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

kaijchen opened a new pull request, #30750:
URL: https://github.com/apache/doris/pull/30750

   ## Proposed changes
   
   `remain_ms` should be a signed value.
   Also, we should update remain_ms before each close_wait.
   
   ```
   (gdb) p remain_ms
   $10 = 18446744073709551611
   ```
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923189071

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36563 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17673	4492	4437	4437
   q2	2054	138	127	127
   q3	10602	904	897	897
   q4	4645	726	689	689
   q5	7671	2824	2726	2726
   q6	186	123	122	122
   q7	1138	712	694	694
   q8	9270	1966	1985	1966
   q9	7152	6330	6274	6274
   q10	8079	2461	2420	2420
   q11	406	211	206	206
   q12	742	281	271	271
   q13	18015	3313	3252	3252
   q14	270	251	245	245
   q15	544	487	485	485
   q16	441	397	402	397
   q17	915	545	508	508
   q18	6787	5967	5859	5859
   q19	1583	1469	1335	1335
   q20	596	326	313	313
   q21	6626	3051	3039	3039
   q22	814	312	301	301
   Total cold run time: 106209 ms
   Total hot run time: 36563 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4538	4406	4471	4406
   q2	339	237	227	227
   q3	2999	2818	2766	2766
   q4	1901	1594	1630	1594
   q5	5179	5211	5164	5164
   q6	190	113	114	113
   q7	2099	1725	1757	1725
   q8	3041	3204	3213	3204
   q9	8260	8282	8244	8244
   q10	5948	3536	3544	3536
   q11	544	444	442	442
   q12	724	571	562	562
   q13	14242	3111	3043	3043
   q14	280	241	264	241
   q15	530	490	487	487
   q16	501	462	461	461
   q17	1830	1663	1665	1663
   q18	7969	7610	7528	7528
   q19	9165	1545	1530	1530
   q20	2118	1890	1900	1890
   q21	4733	4509	4638	4509
   q22	527	479	471	471
   Total cold run time: 77657 ms
   Total hot run time: 53806 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923115382

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #30750:
URL: https://github.com/apache/doris/pull/30750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923241938

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
   Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923234517

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.05 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.03
   query3	0.23	0.06	0.06
   query4	1.65	0.10	0.09
   query5	0.55	0.52	0.51
   query6	1.17	0.64	0.63
   query7	0.01	0.01	0.01
   query8	0.04	0.02	0.03
   query9	0.54	0.49	0.50
   query10	0.55	0.53	0.56
   query11	0.12	0.08	0.08
   query12	0.11	0.08	0.09
   query13	0.61	0.60	0.60
   query14	0.80	0.80	0.80
   query15	0.79	0.79	0.79
   query16	0.40	0.37	0.39
   query17	0.98	1.00	1.00
   query18	0.20	0.28	0.24
   query19	1.80	1.71	1.74
   query20	0.01	0.02	0.02
   query21	15.40	0.60	0.57
   query22	2.81	2.63	1.45
   query23	17.16	0.92	0.74
   query24	2.62	0.62	1.11
   query25	0.43	0.18	0.08
   query26	0.46	0.14	0.15
   query27	0.06	0.04	0.06
   query28	12.46	0.85	0.83
   query29	12.47	3.13	3.11
   query30	0.62	0.50	0.53
   query31	2.79	0.33	0.35
   query32	3.36	0.48	0.49
   query33	3.20	3.23	3.25
   query34	15.75	4.28	4.36
   query35	4.37	4.31	4.25
   query36	1.12	1.05	1.08
   query37	0.07	0.05	0.05
   query38	0.04	0.02	0.02
   query39	0.03	0.02	0.01
   query40	0.16	0.16	0.14
   query41	0.07	0.02	0.02
   query42	0.02	0.01	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 106.15 s
   Total hot run time: 30.05 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923218885

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173227 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f, data reload: false
   
   query1	942	338	327	327
   query2	6553	1917	1862	1862
   query3	6698	201	195	195
   query4	31531	22060	22056	22056
   query5	4287	319	314	314
   query6	244	149	148	148
   query7	4703	264	261	261
   query8	245	170	180	170
   query9	9174	2290	2275	2275
   query10	413	202	204	202
   query11	19095	15306	15218	15218
   query12	117	68	69	68
   query13	1618	385	370	370
   query14	9050	7155	7128	7128
   query15	233	179	190	179
   query16	7877	273	250	250
   query17	1846	484	464	464
   query18	2059	263	240	240
   query19	218	131	127	127
   query20	70	67	70	67
   query21	201	133	129	129
   query22	4816	4591	4575	4575
   query23	30839	30159	30058	30058
   query24	10512	2760	2721	2721
   query25	519	307	307	307
   query26	701	133	137	133
   query27	2289	281	282	281
   query28	5984	1870	1868	1868
   query29	929	612	613	612
   query30	280	129	135	129
   query31	907	684	736	684
   query32	89	53	46	46
   query33	618	207	197	197
   query34	917	456	452	452
   query35	867	758	743	743
   query36	1030	929	929	929
   query37	88	57	55	55
   query38	3169	3089	3072	3072
   query39	1290	1249	1256	1249
   query40	197	85	84	84
   query41	36	35	34	34
   query42	88	78	79	78
   query43	473	474	500	474
   query44	1042	689	705	689
   query45	192	179	175	175
   query46	1069	630	629	629
   query47	1504	1451	1418	1418
   query48	386	317	300	300
   query49	1110	276	278	276
   query50	695	299	312	299
   query51	5282	5199	5094	5094
   query52	90	74	77	74
   query53	320	257	267	257
   query54	279	177	174	174
   query55	79	76	76	76
   query56	175	151	157	151
   query57	927	889	895	889
   query58	189	155	151	151
   query59	2350	2258	2400	2258
   query60	205	172	172	172
   query61	83	84	85	84
   query62	640	365	341	341
   query63	280	264	261	261
   query64	4880	3647	3407	3407
   query65	3216	3196	3205	3196
   query66	922	314	311	311
   query67	14424	14010	14040	14010
   query68	5047	496	496	496
   query69	461	323	306	306
   query70	1273	1192	1226	1192
   query71	305	198	214	198
   query72	6136	3127	2845	2845
   query73	688	331	315	315
   query74	6609	6231	6207	6207
   query75	3010	2297	2320	2297
   query76	3020	966	901	901
   query77	357	228	217	217
   query78	9165	8680	8621	8621
   query79	3455	484	481	481
   query80	2345	318	311	311
   query81	543	192	194	192
   query82	1575	79	85	79
   query83	388	118	119	118
   query84	285	73	66	66
   query85	1547	350	348	348
   query86	465	317	291	291
   query87	3384	3203	3196	3196
   query88	3966	2173	2161	2161
   query89	425	352	373	352
   query90	1815	184	181	181
   query91	144	118	117	117
   query92	50	46	41	41
   query93	3985	453	420	420
   query94	1356	158	158	158
   query95	461	346	333	333
   query96	608	310	314	310
   query97	4239	4078	4095	4078
   query98	219	201	188	188
   query99	1164	688	695	688
   Total cold run time: 282641 ms
   Total hot run time: 173227 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923360278

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923360330

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923070638

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923071348

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](move-memtable) use signed integer when calculating remain ms [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30750:
URL: https://github.com/apache/doris/pull/30750#issuecomment-1923183884

   TeamCity be ut coverage result:
    Function Coverage: 36.16% (8622/23846) 
    Line Coverage: 28.21% (70493/249896)
    Region Coverage: 27.23% (36379/133621)
    Branch Coverage: 24.01% (18630/77582)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f_9d9d3c3ebf36e9ced0d40611f0ad520c8937fc1f/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org