You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org> on 2005/06/14 17:38:46 UTC

[jira] Created: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Added equals(Object) methods to filter nodes.
---------------------------------------------

         Key: DIRLDAP-41
         URL: http://issues.apache.org/jira/browse/DIRLDAP-41
     Project: Directory LDAP
        Type: New Feature
  Components: Common  
    Versions: 0.9.1    
    Reporter: Jacob S. Barrett
 Assigned to: Alex Karasulu 
    Priority: Minor
 Attachments: filter-equals.patch

The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/DIRLDAP-41?page=comments#action_12313786 ] 

Alex Karasulu commented on DIRLDAP-41:
--------------------------------------

This patch had 2 rejects in it for some reason.  The SimpleNode and BranchNode changes did not succeed.  

> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>          Key: DIRLDAP-41
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-41
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.1
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: filter-equals.patch
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-41?page=all ]
     
Alex Karasulu resolved DIRLDAP-41:
----------------------------------

    Fix Version: 0.9.1
     Resolution: Fixed

I'll close this but will need to get some test cases from ya for code coverage reasons.  Here's the commit revision and the log:

190873 

http://svn.apache.org/viewcvs.cgi?rev=190873&view=rev

> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>          Key: DIRLDAP-41
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-41
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.1
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Minor
>      Fix For: 0.9.1
>  Attachments: filter-equals.patch
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-41?page=all ]

Jacob S. Barrett updated DIRLDAP-41:
------------------------------------

    Attachment: SimpleNodeTest.java
                BranchNodeTest.java

Imagine that, I had already done JUnits for them.  Where is my brain?

> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>          Key: DIRLDAP-41
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-41
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.1
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Minor
>      Fix For: 0.9.1
>  Attachments: BranchNodeTest.java, SimpleNodeTest.java, filter-equals.patch
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/DIRLDAP-41?page=comments#action_12313794 ] 

Alex Karasulu commented on DIRLDAP-41:
--------------------------------------

Looks like the problem was the solaris patch program.  I patched the files by samba mounting and running cygwin patch just fine.  This was odd.  Anyway I'll install patchutils rather than using native Solaris patch.

BTW these look good ... I simplified some of your long return lines ;) though.  Any chance you can submit an addendum patch to this one that contains test cases for these equals() methods?  


> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>          Key: DIRLDAP-41
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-41
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.1
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: filter-equals.patch
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (DIRSERVER-211) Added equals(Object) methods to filter nodes.

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRSERVER-211.
---------------------------------------


Closing all issues created in 2005 and before which are marked resolved

> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>                 Key: DIRSERVER-211
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-211
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: ldap
>    Affects Versions: pre-1.0
>            Reporter: Jacob S. Barrett
>         Assigned To: Alex Karasulu
>            Priority: Minor
>             Fix For: pre-1.0
>
>         Attachments: BranchNodeTest.java, filter-equals.patch, SimpleNodeTest.java
>
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DIRLDAP-41) Added equals(Object) methods to filter nodes.

Posted by "Jacob S. Barrett (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-41?page=all ]

Jacob S. Barrett updated DIRLDAP-41:
------------------------------------

    Attachment: filter-equals.patch

Patch to add equals(Object) to some of the Node classes.

> Added equals(Object) methods to filter nodes.
> ---------------------------------------------
>
>          Key: DIRLDAP-41
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-41
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.1
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: filter-equals.patch
>
> The attached patch adds the equals(Object) method to some of the Node classes.  There is no real need for these as of yet outside of JUNIT testing things.  I use them for testing part of my project.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira