You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/17 09:55:53 UTC
[GitHub] [flink] twalthr commented on a change in pull request #8762:
[FLINK-12844][table-planner-blink] Use default conversion class
LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in
blink
twalthr commented on a change in pull request #8762: [FLINK-12844][table-planner-blink] Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink
URL: https://github.com/apache/flink/pull/8762#discussion_r294220400
##########
File path: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
##########
@@ -1713,6 +1714,12 @@ private static Type materializeTypeVariable(ArrayList<Type> typeHierarchy, TypeV
return timeTypeInfo;
}
+ // check for SQL time types
+ TypeInformation<OUT> localTimeTypeInfo = LocalTimeTypeInfo.getInfoFor(clazz);
Review comment:
Changes in the type extractor lead to breaking backwards compatibility. So far we don't have a migration path from one serializer to another. Right, @tzulitai?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services