[GitHub] Ovilia closed pull request #9195: axisLine.show option implemented for Gauge

[GitBox <gi...@apache.org>]

Ovilia closed pull request #9195: axisLine.show option implemented for Gauge
URL: https://github.com/apache/incubator-echarts/pull/9195
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/chart/gauge/GaugeView.js b/src/chart/gauge/GaugeView.js
index 3ec04399f..567f72ec4 100644
--- a/src/chart/gauge/GaugeView.js
+++ b/src/chart/gauge/GaugeView.js
@@ -85,8 +85,9 @@ var GaugeView = ChartView.extend({
 
         var prevEndAngle = startAngle;
         var axisLineWidth = lineStyleModel.get('width');
-
-        for (var i = 0; i < colorList.length; i++) {
+        var showAxis = axisLineModel.get('show');
+        
+        for (var i = 0; showAxis && i < colorList.length; i++) {
             // Clamp
             var percent = Math.min(Math.max(colorList[i][0], 0), 1);
             var endAngle = startAngle + angleRangeSpan * percent;
@@ -424,4 +425,4 @@ var GaugeView = ChartView.extend({
     }
 });
 
-export default GaugeView;
\ No newline at end of file
+export default GaugeView;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org