You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "murfffi (via GitHub)" <gi...@apache.org> on 2025/03/24 16:18:18 UTC
[PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
murfffi opened a new pull request, #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637
Implements reading from union types and adds a unit test. All tests pass, except those with C shared object dependencies - I did not build the code outside go/adbc.
Closes #2636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2762950279
Incrementally adding support should be fine. so not supporting nested unions for now is fair. Besides, it just means it's a good reason to use the Arrow interfaces directly instead :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2783626101
Sorry, been super crazy on my end last week. This looks good! thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "murfffi (via GitHub)" <gi...@apache.org>.
murfffi commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2762521314
Thanks for taking a look! Will add the tests.
Are you okay with not supporting nested unions? I could have added a loop for that but I thought the added complexity wasn't worth the questionable value of nested unions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2770512017
Squashed commits aren't necessary since we're going to squash it anyways when we merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "murfffi (via GitHub)" <gi...@apache.org>.
murfffi commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2783628172
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "murfffi (via GitHub)" <gi...@apache.org>.
murfffi commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2763233240
> Sorry for the delay on the response here, this looks good to me in general, but can we add a test which contains more than one type in the union? With results from both types and ensure that we get the correct values for each index?
>
> Also, can we please add a test for DenseUnion in addition to the test with SparseUnion?
Added. Forgot to ask if squashed commits are preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "murfffi (via GitHub)" <gi...@apache.org>.
murfffi commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2783515766
Any comments on the latest changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/sqldriver): read from union types [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org