You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2017/12/31 16:18:00 UTC

[jira] [Commented] (ISIS-1774) Handle N+1 issue for first page and subsequent pages.

    [ https://issues.apache.org/jira/browse/ISIS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307240#comment-16307240 ] 

Dan Haywood commented on ISIS-1774:
-----------------------------------

Have added "isis.persistor.datanucleus.standaloneCollection.bulkLoad" as a configuration property to enable the loading of rendered objects in a standalone collection.

The implementation falls back to a one-by-one load if any of the objects are deleted in between the action interaction phase and the rendering phase.

For safety, the default of this config property is false, but has been set explicitly to true in the example app so that new apps based on the archetype will start to use this setting.

Note that there is room for improvement ... currently it loads all of the objects in a single go, and does not pay any attention to the paging.  An improvement would be to pay attention to this and only load those objects required for the current page (the information is available).  One complicaiton though is that client-side app tenancy filtering might result in some of the loaded objects being hidden for the current user, and so it would be necessary to query using some sort of do... while { } to keep retrieving batches until enough (non-client-side-filtered-out) objects to populate the current page were obtained.



> Handle N+1 issue for first page and subsequent pages.
> -----------------------------------------------------
>
>                 Key: ISIS-1774
>                 URL: https://issues.apache.org/jira/browse/ISIS-1774
>             Project: Isis
>          Issue Type: Improvement
>    Affects Versions: 1.15.1
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.16.0
>
>
> see users ML 
> https://lists.apache.org/thread.html/77a07739053fa8d6fa544e60590720e1457e47371d407828ab36846f@%3Cusers.isis.apache.org%3E
> One option is to switch to REDIRECT_TO_BUFFER to avoid N+1 issue, provide optional configuration property to revert if required
> However, this only handles the first page; subsequent pages will still generate N requests.
> Further discussion in email thread.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)