You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/12/11 14:56:56 UTC

[PR] Minor: make unsupported `nanosecond` part a real (not internal) error [datafusion]

alamb opened a new pull request, #13733:
URL: https://github.com/apache/datafusion/pull/13733

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   
   I noticed this while working on https://github.com/apache/datafusion/pull/13732
   
   Extracting nanoseconds from a timestamp is not supported, but currently that is marked as in internal error. Let's make it the proper code (not supported)
   
   
   
   ## What changes are included in this PR?
   
   Changes:
   1. Change error to be "unsupported" rather than internal
   
   
   ## Are these changes tested?
   
   Yes, this change is covered by tests (see updates)
   
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Minor: make unsupported `nanosecond` part a real (not internal) error [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #13733:
URL: https://github.com/apache/datafusion/pull/13733#issuecomment-2539036584

   > > ... unsupported nanosecond part
   > 
   > nanosecond part or nanosecond unit?
   
   I double checked @findepi  and indeed this is the nanosecond part, so I improved the message in 95d0dd5de 
   
   Thank you @xudong963 for the review 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Minor: make unsupported `nanosecond` part a real (not internal) error [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13733:
URL: https://github.com/apache/datafusion/pull/13733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Minor: make unsupported `nanosecond` part a real (not internal) error [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #13733:
URL: https://github.com/apache/datafusion/pull/13733#discussion_r1880359622


##########
datafusion/sqllogictest/test_files/expr/date_part.slt:
##########
@@ -225,7 +225,7 @@ SELECT EXTRACT(microsecond FROM timestamp '2020-09-08T12:00:12.12345678+00:00')
 ----
 12123456
 
-query error DataFusion error: Internal error: unit Nanosecond not supported
+query error DataFusion error: This feature is not implemented: unit Nanosecond not supported

Review Comment:
   This demonstrates the behavior change -- it is not an internal error anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org