[GitHub] [iceberg] yyanyy commented on pull request #2083: Fix the partition field id when appending a field to the V2 spec.

[GitBox <gi...@apache.org>]

yyanyy commented on pull request #2083:
URL: https://github.com/apache/iceberg/pull/2083#issuecomment-759833051


   > Good catch. We also still need to add a `lastAssignedFieldId` to table metadata for this, like we have for last assigned column ID.
   
   Is this just to ensure implementation correctness per spec? As it seems that from the current implementation getting this from `PartitionSpec::lastAssignedFieldId` should be good enough, as there's no table operation to actually remove a partition field from specs? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org