You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ja...@apache.org on 2020/03/24 23:03:08 UTC
[hbase] branch master updated: HBASE-23983 Fixed Spotbugs complaint
in RegionStates related to ignored return value
This is an automated email from the ASF dual-hosted git repository.
janh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/master by this push:
new aa966e3 HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
aa966e3 is described below
commit aa966e354aa02f5572fc06427dfa0617b4e0123b
Author: Jan Hentschel <ja...@ultratendency.com>
AuthorDate: Wed Mar 25 00:02:54 2020 +0100
HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
Signed-off-by: Duo Zhang <zh...@apache.org>
---
.../org/apache/hadoop/hbase/master/assignment/RegionStates.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
index 7c0f6f8..3bb3c4c 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
@@ -129,7 +129,11 @@ public class RegionStates {
synchronized (regionsMapLock) {
RegionStateNode node = regionsMap.computeIfAbsent(regionInfo.getRegionName(),
key -> new RegionStateNode(regionInfo, regionInTransition));
- encodedRegionsMap.putIfAbsent(regionInfo.getEncodedName(), node);
+
+ if (encodedRegionsMap.get(regionInfo.getEncodedName()) != node) {
+ encodedRegionsMap.put(regionInfo.getEncodedName(), node);
+ }
+
return node;
}
}