You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "luoyuxia (via GitHub)" <gi...@apache.org> on 2026/02/08 03:46:32 UTC
[PR] feat: support database-level ops [fluss-rust]
luoyuxia opened a new pull request, #279:
URL: https://github.com/apache/fluss-rust/pull/279
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #275
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support database-level ops [fluss-rust]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #279:
URL: https://github.com/apache/fluss-rust/pull/279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support database-level ops [fluss-rust]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #279:
URL: https://github.com/apache/fluss-rust/pull/279#discussion_r2778507732
##########
bindings/python/src/admin.rs:
##########
@@ -59,6 +57,242 @@ fn validate_bucket_ids(bucket_ids: &[i32]) -> PyResult<()> {
#[pymethods]
impl FlussAdmin {
+ /// Create a database.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ /// ignore_if_exists: If True, don't raise error if database already exists
+ /// database_descriptor: Optional descriptor (comment, custom_properties)
+ ///
+ /// Returns:
+ /// None
+ #[pyo3(signature = (database_name, ignore_if_exists=false, database_descriptor=None))]
+ pub fn create_database<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ignore_if_exists: bool,
+ database_descriptor: Option<&DatabaseDescriptor>,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+ let descriptor = database_descriptor.map(|d| d.to_core().clone());
+
+ future_into_py(py, async move {
+ admin
+ .create_database(&name, ignore_if_exists, descriptor.as_ref())
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to create database: {e}")))?;
+
+ Python::attach(|py| Ok(py.None()))
+ })
+ }
+
+ /// Drop a database.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ /// ignore_if_not_exists: If True, don't raise error if database does not exist
+ /// cascade: If True, drop tables in the database first
+ ///
+ /// Returns:
+ /// None
+ #[pyo3(signature = (database_name, ignore_if_not_exists=false, cascade=true))]
+ pub fn drop_database<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ignore_if_not_exists: bool,
+ cascade: bool,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ admin
+ .drop_database(&name, ignore_if_not_exists, cascade)
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to drop database: {e}")))?;
+
+ Python::attach(|py| Ok(py.None()))
+ })
+ }
+
+ /// List all databases.
+ ///
+ /// Returns:
+ /// List[str]: Names of all databases
+ pub fn list_databases<'py>(&self, py: Python<'py>) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+
+ future_into_py(py, async move {
+ let names = admin
+ .list_databases()
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to list databases: {e}")))?;
+
+ Python::attach(|py| {
+ let py_list = pyo3::types::PyList::empty(py);
+ for name in names {
+ py_list.append(name)?;
+ }
+ Ok(py_list.unbind())
+ })
+ })
+ }
+
+ /// Check if a database exists.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ ///
+ /// Returns:
+ /// bool: True if the database exists
+ pub fn database_exists<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ let exists = admin.database_exists(&name).await.map_err(|e| {
+ FlussError::new_err(format!("Failed to check database exists: {e}"))
+ })?;
+
+ Python::attach(|py| {
+ let builtins = py.import("builtins")?;
+ let val = if exists {
+ builtins.getattr("True")?
+ } else {
+ builtins.getattr("False")?
+ };
+ Ok(val.unbind())
+ })
+ })
+ }
+
+ /// Get database information.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ ///
+ /// Returns:
+ /// DatabaseInfo: Database metadata
+ pub fn get_database_info<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ let info = admin
+ .get_database_info(&name)
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to get database info: {e}")))?;
+
+ Python::attach(|py| Py::new(py, DatabaseInfo::from_core(info)))
+ })
+ }
+
+ /// List all tables in a database.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ ///
+ /// Returns:
+ /// List[str]: Names of all tables in the database
+ pub fn list_tables<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ let names = admin
+ .list_tables(&name)
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to list tables: {e}")))?;
+
+ Python::attach(|py| {
+ let py_list = pyo3::types::PyList::empty(py);
+ for name in names {
+ py_list.append(name)?;
+ }
+ Ok(py_list.unbind())
+ })
+ })
+ }
+
+ /// Check if a table exists.
+ ///
+ /// Args:
+ /// table_path: Path to the table (database, table)
+ ///
+ /// Returns:
+ /// bool: True if the table exists
+ pub fn table_exists<'py>(
+ &self,
+ py: Python<'py>,
+ table_path: &TablePath,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let core_table_path = table_path.to_core();
+ let admin = self.__admin.clone();
+
+ future_into_py(py, async move {
+ let exists = admin
+ .table_exists(&core_table_path)
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to check table exists: {e}")))?;
+
+ Python::attach(|py| {
+ let builtins = py.import("builtins")?;
+ let val = if exists {
+ builtins.getattr("True")?
+ } else {
+ builtins.getattr("False")?
+ };
+ Ok(val.unbind())
+ })
+ })
+ }
+
Review Comment:
`table_exists` converts a Rust `bool` to Python by importing `builtins` and fetching "True"/"False". This adds avoidable overhead; prefer returning the `bool` directly via PyO3 conversion APIs (e.g., `exists.into_py(py)` / `PyBool`).
##########
bindings/python/src/admin.rs:
##########
@@ -59,6 +57,242 @@ fn validate_bucket_ids(bucket_ids: &[i32]) -> PyResult<()> {
#[pymethods]
impl FlussAdmin {
+ /// Create a database.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ /// ignore_if_exists: If True, don't raise error if database already exists
+ /// database_descriptor: Optional descriptor (comment, custom_properties)
+ ///
+ /// Returns:
+ /// None
+ #[pyo3(signature = (database_name, ignore_if_exists=false, database_descriptor=None))]
+ pub fn create_database<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ignore_if_exists: bool,
+ database_descriptor: Option<&DatabaseDescriptor>,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+ let descriptor = database_descriptor.map(|d| d.to_core().clone());
+
+ future_into_py(py, async move {
+ admin
+ .create_database(&name, ignore_if_exists, descriptor.as_ref())
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to create database: {e}")))?;
+
+ Python::attach(|py| Ok(py.None()))
+ })
+ }
+
+ /// Drop a database.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ /// ignore_if_not_exists: If True, don't raise error if database does not exist
+ /// cascade: If True, drop tables in the database first
+ ///
+ /// Returns:
+ /// None
+ #[pyo3(signature = (database_name, ignore_if_not_exists=false, cascade=true))]
+ pub fn drop_database<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ignore_if_not_exists: bool,
+ cascade: bool,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ admin
+ .drop_database(&name, ignore_if_not_exists, cascade)
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to drop database: {e}")))?;
+
+ Python::attach(|py| Ok(py.None()))
+ })
+ }
+
+ /// List all databases.
+ ///
+ /// Returns:
+ /// List[str]: Names of all databases
+ pub fn list_databases<'py>(&self, py: Python<'py>) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+
+ future_into_py(py, async move {
+ let names = admin
+ .list_databases()
+ .await
+ .map_err(|e| FlussError::new_err(format!("Failed to list databases: {e}")))?;
+
+ Python::attach(|py| {
+ let py_list = pyo3::types::PyList::empty(py);
+ for name in names {
+ py_list.append(name)?;
+ }
+ Ok(py_list.unbind())
+ })
+ })
+ }
+
+ /// Check if a database exists.
+ ///
+ /// Args:
+ /// database_name: Name of the database
+ ///
+ /// Returns:
+ /// bool: True if the database exists
+ pub fn database_exists<'py>(
+ &self,
+ py: Python<'py>,
+ database_name: &str,
+ ) -> PyResult<Bound<'py, PyAny>> {
+ let admin = self.__admin.clone();
+ let name = database_name.to_string();
+
+ future_into_py(py, async move {
+ let exists = admin.database_exists(&name).await.map_err(|e| {
+ FlussError::new_err(format!("Failed to check database exists: {e}"))
+ })?;
+
+ Python::attach(|py| {
+ let builtins = py.import("builtins")?;
+ let val = if exists {
+ builtins.getattr("True")?
+ } else {
+ builtins.getattr("False")?
+ };
+ Ok(val.unbind())
+ })
+ })
+ }
+
Review Comment:
`database_exists` converts a Rust `bool` to Python by importing `builtins` and fetching "True"/"False". This is unnecessary overhead and less idiomatic in PyO3; you can return the boolean directly (e.g., convert `exists` with `IntoPy`/`to_object` or `PyBool`) inside the `Python::attach` closure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org