You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <iv...@visualsvn.com> on 2013/06/29 21:05:19 UTC

Re: svn commit: r1497975 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_subr/config_file.c

On Saturday, June 29, 2013, wrote:

> Author: gstein
> Date: Sat Jun 29 02:00:07 2013
> New Revision: 1497975
>
> URL: http://svn.apache.org/r1497975
> Log:
> Switch the config name and semantics to busted-proxy.
>
> For now, it retains the static configuration-based behavior. Future
> work will perform runtime detection.
>
> * subversion/include/svn_config.h:
>   (SVN_CONFIG_OPTION_HTTP_CHUNKED_REQUESTS): renamed to ...
>   (SVN_CONFIG_OPTION_BUSTED_PROXY): ... this
>
> * subversion/libsvn_ra_serf/ra_serf.h:
>   (svn_ra_serf__session_t): change USING_PROXY to boolean. add
>     BUSTED_PROXY flag (loaded from config)
>
> * subversion/libsvn_ra_serf/serf.c:
>   (load_config): load the BUSTED_PROXY configuration data. if a proxy
>     is being used and the proxy may be busted, then disable chunked
>     requests
>   (svn_ra_serf__open): initialize USING_CHUNKED_REQUESTS
>
> * subversion/libsvn_subr/config_file.c:
>   (svn_config_ensure): rename flag and adjust description
>
> As I already said on the list forward (client side) proxies are not issue
anyway: most forward proxies does not support HTTP methods other than
GET/POST. https proxies are not issue since it is only tunnel. And actually
nobody complained about forward proxies.

Problem is reverse proxy, while you patch does not help for case reported
many times.

----
Ivan Zhakov


-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com

Re: svn commit: r1497975 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_subr/config_file.c

Posted by Greg Stein <gs...@gmail.com>.
On Sat, Jun 29, 2013 at 3:05 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Saturday, June 29, 2013, wrote:
>>
>> Author: gstein
>> Date: Sat Jun 29 02:00:07 2013
>> New Revision: 1497975
>>
>> URL: http://svn.apache.org/r1497975
>> Log:
>> Switch the config name and semantics to busted-proxy.
>>
>> For now, it retains the static configuration-based behavior. Future
>> work will perform runtime detection.
>>
>> * subversion/include/svn_config.h:
>>   (SVN_CONFIG_OPTION_HTTP_CHUNKED_REQUESTS): renamed to ...
>>   (SVN_CONFIG_OPTION_BUSTED_PROXY): ... this
>>
>> * subversion/libsvn_ra_serf/ra_serf.h:
>>   (svn_ra_serf__session_t): change USING_PROXY to boolean. add
>>     BUSTED_PROXY flag (loaded from config)
>>
>> * subversion/libsvn_ra_serf/serf.c:
>>   (load_config): load the BUSTED_PROXY configuration data. if a proxy
>>     is being used and the proxy may be busted, then disable chunked
>>     requests
>>   (svn_ra_serf__open): initialize USING_CHUNKED_REQUESTS
>>
>> * subversion/libsvn_subr/config_file.c:
>>   (svn_config_ensure): rename flag and adjust description
>
> As I already said on the list forward (client side) proxies are not issue

Sure, I saw that but just hadn't fixed it yet.

Now done in r1498012.

>...

Cheers,
-g

Re: svn commit: r1497975 - in /subversion/trunk/subversion: include/svn_config.h libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_subr/config_file.c

Posted by Greg Stein <gs...@gmail.com>.
On Sat, Jun 29, 2013 at 3:05 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Saturday, June 29, 2013, wrote:
>>
>> Author: gstein
>> Date: Sat Jun 29 02:00:07 2013
>> New Revision: 1497975
>>
>> URL: http://svn.apache.org/r1497975
>> Log:
>> Switch the config name and semantics to busted-proxy.
>>
>> For now, it retains the static configuration-based behavior. Future
>> work will perform runtime detection.
>>
>> * subversion/include/svn_config.h:
>>   (SVN_CONFIG_OPTION_HTTP_CHUNKED_REQUESTS): renamed to ...
>>   (SVN_CONFIG_OPTION_BUSTED_PROXY): ... this
>>
>> * subversion/libsvn_ra_serf/ra_serf.h:
>>   (svn_ra_serf__session_t): change USING_PROXY to boolean. add
>>     BUSTED_PROXY flag (loaded from config)
>>
>> * subversion/libsvn_ra_serf/serf.c:
>>   (load_config): load the BUSTED_PROXY configuration data. if a proxy
>>     is being used and the proxy may be busted, then disable chunked
>>     requests
>>   (svn_ra_serf__open): initialize USING_CHUNKED_REQUESTS
>>
>> * subversion/libsvn_subr/config_file.c:
>>   (svn_config_ensure): rename flag and adjust description
>
> As I already said on the list forward (client side) proxies are not issue

Sure, I saw that but just hadn't fixed it yet.

Now done in r1498012.

>...

Cheers,
-g