Re: cvs commit: avalon-logkit/src/test/org/apache/log/test LoggerListenerTestCase.java RecordingLoggerListener.java

[Peter Donald <pe...@realityforge.org>]

On Fri, 7 Feb 2003 08:15, bloritsch@apache.org wrote:
>   +    public synchronized LoggerListener[] getLoggerListeners()
>   +    {
>   +        LoggerListener[] listeners = null;
>   +
>   +        if ( null == m_loggerListener )
>   +        {
>   +            listeners = new LoggerListener[] {};
>   +        }
>   +        else
>   +        {
>   +            listeners = new LoggerListener[] {m_loggerListener};
>   +        }
>   +
>   +        return listeners;
>   +    }

We dont want users being able to access thess objects.

On Fri, 7 Feb 2003 08:15, bloritsch@apache.org wrote:
+    public synchronized void removeLoggerListener( final LoggerListener loggerListener ) 
+    {
+        if ( null == loggerListener ) throw new NullPointerException("loggerListener" ); 
+
+        if ( null != m_loggerListener && m_loggerListener.equals( loggerListener ) ); 


And nor do we want to do deep compares as a dodgy loggerlistener could throw an exception in
 equals. It would be better to replace this with an identity equality test.


-- 
Cheers,

Peter Donald
*------------------------------------------------------*
| An expert is someone who knows everything about the  |
| topic except for its place in the world.             |
*------------------------------------------------------*


---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org