You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/12/30 14:34:16 UTC
[GitHub] [lucene] twosom opened a new pull request, #12047: fix typo analysis-kuromoji
twosom opened a new pull request, #12047:
URL: https://github.com/apache/lucene/pull/12047
### Description
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] twosom commented on pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
twosom commented on PR #12047:
URL: https://github.com/apache/lucene/pull/12047#issuecomment-1368474848
@msokolov
Thanks~!
and Happy New Year!👻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] twosom commented on a diff in pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
twosom commented on code in PR #12047:
URL: https://github.com/apache/lucene/pull/12047#discussion_r1059413652
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -39,9 +39,9 @@
* <p>Notice that this analyzer uses a token composition scheme and relies on punctuation tokens
* being found in the token stream. Please make sure your {@link JapaneseTokenizer} has {@code
* discardPunctuation} set to false. In case punctuation characters, such as ． (U+FF0E FULLWIDTH
- * FULL STOP), is removed from the token stream, this filter would find input tokens tokens ３ and ２千
Review Comment:
removed repeated words `tokens tokens`.
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -59,8 +59,8 @@
* <li>15,7 becomes 157 (be aware of this weakness)
* </ul>
*
- * <p>Tokens preceded by a token with {@link PositionIncrementAttribute} of zero are left left
Review Comment:
removed repeated words `left left`
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/completion/CharSequenceUtils.java:
##########
@@ -72,7 +72,7 @@ public static boolean isFullWidthLowercaseAlphabet(char ch) {
return ch >= 0xff41 && ch <= 0xff5a;
}
- /** Convert all hiragana in a string into kanataka */
Review Comment:
fix spelling `kanataka` to `katakana`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov merged pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
msokolov merged PR #12047:
URL: https://github.com/apache/lucene/pull/12047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] twosom commented on a diff in pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
twosom commented on code in PR #12047:
URL: https://github.com/apache/lucene/pull/12047#discussion_r1059413652
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -39,9 +39,9 @@
* <p>Notice that this analyzer uses a token composition scheme and relies on punctuation tokens
* being found in the token stream. Please make sure your {@link JapaneseTokenizer} has {@code
* discardPunctuation} set to false. In case punctuation characters, such as ． (U+FF0E FULLWIDTH
- * FULL STOP), is removed from the token stream, this filter would find input tokens tokens ３ and ２千
Review Comment:
removed repeated words `tokens tokens`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] twosom commented on a diff in pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
twosom commented on code in PR #12047:
URL: https://github.com/apache/lucene/pull/12047#discussion_r1059413853
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/completion/CharSequenceUtils.java:
##########
@@ -72,7 +72,7 @@ public static boolean isFullWidthLowercaseAlphabet(char ch) {
return ch >= 0xff41 && ch <= 0xff5a;
}
- /** Convert all hiragana in a string into kanataka */
Review Comment:
fix spelling `kanataka` to `katakana`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] twosom commented on a diff in pull request #12047: fix typo analysis-kuromoji
Posted by GitBox <gi...@apache.org>.
twosom commented on code in PR #12047:
URL: https://github.com/apache/lucene/pull/12047#discussion_r1059413723
##########
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/JapaneseNumberFilter.java:
##########
@@ -59,8 +59,8 @@
* <li>15,7 becomes 157 (be aware of this weakness)
* </ul>
*
- * <p>Tokens preceded by a token with {@link PositionIncrementAttribute} of zero are left left
Review Comment:
removed repeated words `left left`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org