[GitHub] [spark] amaliujia commented on a diff in pull request #38807: [SPARK-41270][CONNECT] Add Catalog tableExists and databaseExists in Connect proto

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38807:
URL: https://github.com/apache/spark/pull/38807#discussion_r1037395285


##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -183,6 +183,46 @@ message ExecutePlanResponse {
   }
 }
 
+// Base request to execute Catalog operations.
+message CatalogRequest {

Review Comment:
   I think the only exception case is `createTabe` because it returns a DataFrame.... My understanding is `createTable` should go to `ExecutePlan` rpc, same as other DataFrame API. Because  one could use `createTable` to chain the other DataFrame API.
   
   other API can go through there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org