You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by li...@apache.org on 2010/09/15 03:40:24 UTC
svn commit: r997164 - in
/shindig/trunk/features/src/main/javascript/features:
com.google.gadgets.analytics/ container/ core.config/ core.io/ core.json/
flash/ oauthpopup/ opensocial-data/ opensocial-reference/
opensocial-templates/ opensocial-template...
Author: lindner
Date: Wed Sep 15 01:40:22 2010
New Revision: 997164
URL: http://svn.apache.org/viewvc?rev=997164&view=rev
Log:
more gjslint cleanups
Modified:
shindig/trunk/features/src/main/javascript/features/com.google.gadgets.analytics/analytics.js
shindig/trunk/features/src/main/javascript/features/container/container.js
shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js
shindig/trunk/features/src/main/javascript/features/container/gadget_site.js
shindig/trunk/features/src/main/javascript/features/container/service.js
shindig/trunk/features/src/main/javascript/features/core.config/config.js
shindig/trunk/features/src/main/javascript/features/core.io/io.js
shindig/trunk/features/src/main/javascript/features/core.json/json.js
shindig/trunk/features/src/main/javascript/features/flash/taming.js
shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js
shindig/trunk/features/src/main/javascript/features/opensocial-data/data.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/bodytype.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/email.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/name.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/organization.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/person.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/phone.js
shindig/trunk/features/src/main/javascript/features/opensocial-reference/url.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/base.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/container.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/loader.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/os.js
shindig/trunk/features/src/main/javascript/features/opensocial-templates/template.js
shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js
shindig/trunk/features/src/main/javascript/features/shindig.container/shindig-container.js
shindig/trunk/features/src/main/javascript/features/views/views.js
shindig/trunk/features/src/main/javascript/features/xmlutil/xmlutil.js
Modified: shindig/trunk/features/src/main/javascript/features/com.google.gadgets.analytics/analytics.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/com.google.gadgets.analytics/analytics.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/com.google.gadgets.analytics/analytics.js (original)
+++ shindig/trunk/features/src/main/javascript/features/com.google.gadgets.analytics/analytics.js Wed Sep 15 01:40:22 2010
@@ -18,20 +18,20 @@
*/
(function() {
- gadgets.analytics = function(trackingCode) {
- this.tracker = _gat._getTracker(trackingCode);
- };
+ gadgets.analytics = function(trackingCode) {
+ this.tracker = _gat._getTracker(trackingCode);
+ };
- gadgets.analytics.prototype.reportPageview = function(path) {
- this.tracker._trackPageview(path);
- };
+ gadgets.analytics.prototype.reportPageview = function(path) {
+ this.tracker._trackPageview(path);
+ };
- /**
- * label and value are optional
- */
- gadgets.analytics.prototype.reportEvent = function(name, action, label, value) {
- this.tracker._trackEvent(name, action, label, value);
- };
+ /**
+ * label and value are optional
+ */
+ gadgets.analytics.prototype.reportEvent = function(name, action, label, value) {
+ this.tracker._trackEvent(name, action, label, value);
+ };
}());
var _IG_GA = gadgets.analytics;
Modified: shindig/trunk/features/src/main/javascript/features/container/container.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/container.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/container.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/container.js Wed Sep 15 01:40:22 2010
@@ -33,16 +33,19 @@ shindig.container.Container = function(o
/**
* A JSON list of preloaded gadget URLs.
* @type {Object}
+ * @private
*/
this.preloadedGadgetUrls_ = {};
/**
* @type {Object}
+ * @private
*/
this.sites_ = {};
/**
* @type {string}
+ * @private
*/
this.renderDebugParam_ = String(shindig.container.util.getSafeJsonValue(
config, shindig.container.ContainerConfig.RENDER_DEBUG_PARAM,
@@ -59,6 +62,7 @@ shindig.container.Container = function(o
/**
* @type {boolean}
+ * @private
*/
this.renderTest_ = Boolean(shindig.container.util.getSafeJsonValue(config,
shindig.container.ContainerConfig.RENDER_TEST, false));
@@ -66,6 +70,7 @@ shindig.container.Container = function(o
/**
* Security token refresh interval (in ms) for debugging.
* @type {number}
+ * @private
*/
this.tokenRefreshInterval_ = Number(shindig.container.util.getSafeJsonValue(
config, shindig.container.ContainerConfig.TOKEN_REFRESH_INTERVAL,
@@ -73,12 +78,14 @@ shindig.container.Container = function(o
/**
* @type {shindig.container.Service}
+ * @private
*/
this.service_ = new shindig.container.Service(config);
/**
* result from calling window.setInterval()
* @type {?number}
+ * @private
*/
this.tokenRefreshTimer_ = null;
@@ -243,15 +250,30 @@ shindig.container.Container.prototype.on
* @enum {string}
*/
shindig.container.ContainerConfig = {};
-// Whether debug mode is turned on.
+/**
+ * Whether debug mode is turned on.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerConfig.RENDER_DEBUG = 'renderDebug';
-// The debug param name to look for in container URL for per-request debugging.
+/**
+ * The debug param name to look for in container URL for per-request debugging.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerConfig.RENDER_DEBUG_PARAM = 'renderDebugParam';
-// Whether test mode is turned on.
+/**
+ * Whether test mode is turned on.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerConfig.RENDER_TEST = 'renderTest';
-// Security token refresh interval (in ms) for debugging.
-shindig.container.ContainerConfig.TOKEN_REFRESH_INTERVAL =
- 'tokenRefreshInterval';
+/**
+ * Security token refresh interval (in ms) for debugging.
+ * @type {string}
+ * @const
+ */
+shindig.container.ContainerConfig.TOKEN_REFRESH_INTERVAL = 'tokenRefreshInterval';
/**
@@ -262,17 +284,41 @@ shindig.container.ContainerConfig.TOKEN_
* @enum {string}
*/
shindig.container.ContainerRender = {};
-// Style class to associate to iframe.
+/**
+ * Style class to associate to iframe.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.CLASS = 'class';
-// Whether to turn off debugging.
+/**
+ * Whether to turn off debugging.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.DEBUG = 'debug';
-// The starting/default gadget iframe height (in pixels).
+/**
+ * The starting/default gadget iframe height (in pixels).
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.HEIGHT = 'height';
-// Whether to turn off debugging.
+/**
+ * Whether to turn off debugging.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.TEST = 'test';
-// The gadget view name.
+/**
+ * The gadget view name.
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.VIEW = 'view';
-// The starting/default gadget iframe width (in pixels).
+/**
+ * The starting/default gadget iframe width (in pixels).
+ * @type {string}
+ * @const
+ */
shindig.container.ContainerRender.WIDTH = 'width';
Modified: shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/gadget_holder.js Wed Sep 15 01:40:22 2010
@@ -244,6 +244,7 @@ shindig.container.GadgetHolder.prototype
/**
* Get the rendering iframe URL.
* @private
+ * @return {string} the rendering iframe URL.
*/
shindig.container.GadgetHolder.prototype.getIframeUrl_ = function() {
var uri = shindig.uri(this.gadgetInfo_[shindig.container.MetadataResponse.IFRAME_URL]);
Modified: shindig/trunk/features/src/main/javascript/features/container/gadget_site.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/gadget_site.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/gadget_site.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/gadget_site.js Wed Sep 15 01:40:22 2010
@@ -311,7 +311,7 @@ shindig.container.GadgetSite.prototype.r
* If token has been fetched at least once, set the token to the most recent
* one. Otherwise, leave it.
* @param {Object} gadgetInfo The gadgetInfo used to update security token.
- * @param {Object} renderParams. Render parameters for the gadget, including:
+ * @param {Object} renderParams Render parameters for the gadget, including:
* view, width, and height.
*/
shindig.container.GadgetSite.prototype.updateSecurityToken_
@@ -395,6 +395,7 @@ shindig.container.GadgetSite.prototype.o
/**
* Swap the double buffer elements, if there is a double buffer.
+ * @private
*/
shindig.container.GadgetSite.prototype.swapBuffers_ = function() {
// Only process double buffering if loading gadget exists
Modified: shindig/trunk/features/src/main/javascript/features/container/service.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/service.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/service.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/service.js Wed Sep 15 01:40:22 2010
@@ -32,25 +32,39 @@ shindig.container.Service = function(opt
/**
* @type {string}
+ * @private
*/
this.apiHost_ = String(shindig.container.util.getSafeJsonValue(config,
shindig.container.ServiceConfig.API_HOST, window.__API_URI.getOrigin()));
/**
* @type {string}
+ * @private
*/
this.apiPath_ = String(shindig.container.util.getSafeJsonValue(config,
shindig.container.ServiceConfig.API_PATH, '/api/rpc/cs'));
/**
+<<<<<<< HEAD
+=======
+ * @type {boolean}
+ * @private
+ */
+ this.sameDomain_ = Boolean(shindig.container.util.getSafeJsonValue(config,
+ shindig.container.ServiceConfig.SAME_DOMAIN, false));
+
+ /**
+>>>>>>> more gjslint cleanups
* Map of gadget URLs to cached gadgetInfo response.
* @type {Object}
+ * @private
*/
this.cachedMetadatas_ = {};
/**
* Map of gadget URLs to cached tokenInfo response.
* @type {Object}
+ * @private
*/
this.cachedTokens_ = {};
@@ -63,7 +77,7 @@ shindig.container.Service = function(opt
/**
* Callback that occurs after instantiation/construction of this. Override to
* provide your specific functionalities.
- * @param {Object=} opt_config. Configuration JSON.
+ * @param {Object=} opt_config Configuration JSON.
*/
shindig.container.Service.prototype.onConstructed = function(opt_config) {};
@@ -172,7 +186,16 @@ shindig.container.Service.prototype.init
* @enum {string}
*/
shindig.container.ServiceConfig = {};
-// Host to fetch gadget information, via XHR.
+/**
+ * Host to fetch gadget information, via XHR.
+ * @type {string}
+ * @const
+ */
shindig.container.ServiceConfig.API_HOST = 'apiHost';
-// Path to fetch gadget information, via XHR.
+
+/**
+ * Path to fetch gadget information, via XHR.
+ * @type {string}
+ * @const
+ */
shindig.container.ServiceConfig.API_PATH = 'apiPath';
Modified: shindig/trunk/features/src/main/javascript/features/core.config/config.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.config/config.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.config/config.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.config/config.js Wed Sep 15 01:40:22 2010
@@ -55,7 +55,6 @@
* configuration.
*/
-/** @namespace */
gadgets.config = function() {
var components = {};
var configuration;
Modified: shindig/trunk/features/src/main/javascript/features/core.io/io.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.io/io.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.io/io.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.io/io.js Wed Sep 15 01:40:22 2010
@@ -79,10 +79,10 @@ gadgets.io = function() {
}
try {
if (xobj.status !== 200) {
- var error = ('' + xobj.status);
- if (xobj.responseText) {
- error = error + ' ' + xobj.responseText;
- }
+ var error = ('' + xobj.status);
+ if (xobj.responseText) {
+ error = error + ' ' + xobj.responseText;
+ }
callback({
errors: [error],
rc: xobj.status,
@@ -178,7 +178,7 @@ gadgets.io = function() {
};
if (resp.rc < 200 || resp.rc >= 400) {
- resp.errors = [resp.rc + ' Error'];
+ resp.errors = [resp.rc + ' Error'];
} else if (resp.text) {
if (resp.rc >= 300 && resp.rc < 400) {
// Redirect pages will usually contain arbitrary
@@ -235,6 +235,7 @@ gadgets.io = function() {
* @param {string} proxyUrl The url to proxy through.
* @param {function()} callback The function to call once the data is fetched.
* @param {Object} paramData The params to use when processing the response.
+ * @param {string} method
* @param {function(string,function(Object),Object,Object)}
* processResponseFunction The function that should process the
* response from the sever before calling the callback.
Modified: shindig/trunk/features/src/main/javascript/features/core.json/json.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.json/json.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.json/json.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.json/json.js Wed Sep 15 01:40:22 2010
@@ -209,11 +209,10 @@ if (window.JSON && window.JSON.parse &&
}
/**
* Flatten an object to a stringified values. Useful for dealing with
- * json->querystring transformations.
+ * json->querystring transformations. Note: not in official specification yet
*
- * @param obj {Object}
+ * @param {Object} obj
* @return {Object} object with only string values.
- * @private not in official specification yet
*/
gadgets['json'].flatten = function(obj) {
Modified: shindig/trunk/features/src/main/javascript/features/flash/taming.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/flash/taming.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/flash/taming.js (original)
+++ shindig/trunk/features/src/main/javascript/features/flash/taming.js Wed Sep 15 01:40:22 2010
@@ -93,11 +93,8 @@ tamings___.push(function(imports) {
}
};
- return ___.frozenFunc(function tamedEmbedFlash(
-swfUrl,
-swfContainer,
-swfVersion,
-opt_params ) {
+ return ___.frozenFunc(function tamedEmbedFlash(swfUrl, swfContainer, swfVersion,
+ opt_params) {
// Check that swfContainer is a wrapped node
if (typeof swfContainer === 'string') {
// This assumes that there's only one gadget in the frame.
Modified: shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js (original)
+++ shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js Wed Sep 15 01:40:22 2010
@@ -22,12 +22,6 @@
*/
/**
- * @private
- * @constructor
- */
-
-/**
- * @private
* @constructor
*/
gadgets.oauth = gadgets.oauth || {};
@@ -136,7 +130,7 @@ gadgets.oauth.Popup.prototype.createOpen
/**
* Called when the user clicks to open the popup window.
*
- * @return false to prevent the default action for the click.
+ * @return {boolean} false to prevent the default action for the click.
* @private
*/
gadgets.oauth.Popup.prototype.onClick_ = function() {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-data/data.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-data/data.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-data/data.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-data/data.js Wed Sep 15 01:40:22 2010
@@ -140,6 +140,7 @@ opensocial.data.parseExpression_ = funct
* - Escapes single quotes.
* - Replaces newlines with spaces.
* - Addes single quotes around the string.
+ * @private
*/
opensocial.data.transformLiteral_ = function(string) {
return "'" + string.replace(/'/g, "\\'").
@@ -214,7 +215,7 @@ opensocial.data.RequestDescriptor.protot
* @return {Object} The result of evaluation.
*/
opensocial.data.DataContext.evalExpression = function(expr) {
- return (new Function("context",
+ return (new Function("context",
"with (context) return " + expr))(opensocial.data.DataContext.getData());
};
@@ -363,6 +364,7 @@ opensocial.data.onAPIResponse = function
* Extract the JSON payload from the ResponseItem. This includes
* iterating over an array of API objects and extracting their JSON into a
* simple array structure.
+ * @private
*/
opensocial.data.extractJson_ = function(responseItem, key) {
var data = responseItem.getData();
@@ -461,6 +463,7 @@ opensocial.data.loadRequests = function(
/**
* Parses XML data and constructs the pending request list.
* @param {string} xml A string containing XML markup.
+ * @private
*/
opensocial.data.loadRequestsFromMarkup_ = function(xml) {
xml = opensocial.xmlutil.prepareXML(xml);
@@ -540,6 +543,7 @@ opensocial.data.transformSpecialValue =
* @param {Object} params The params object used to construct an Opensocial
* DataRequest.
* @param {string} fieldsStr A string containing comma-separated field names.
+ * @private
*/
opensocial.data.addFieldsToParams_ = function(params, fieldsStr) {
if (!fieldsStr) {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/bodytype.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/bodytype.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/bodytype.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/bodytype.js Wed Sep 15 01:40:22 2010
@@ -95,7 +95,7 @@ opensocial.BodyType.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.BodyType.Field.html"><code>
- * BodyType.Field</code></a>
+ * BodyType.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/email.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/email.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/email.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/email.js Wed Sep 15 01:40:22 2010
@@ -74,7 +74,7 @@ opensocial.Email.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Email.Field.html"><code>
- * Email.Field</code></a>
+ * Email.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/name.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/name.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/name.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/name.js Wed Sep 15 01:40:22 2010
@@ -101,7 +101,7 @@ opensocial.Name.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Name.Field.html"><code>
- * Name.Field</code></a>
+ * Name.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/organization.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/organization.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/organization.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/organization.js Wed Sep 15 01:40:22 2010
@@ -138,7 +138,7 @@ opensocial.Organization.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Organization.Field.html"><code>
- * Organization.Field</code></a>
+ * Organization.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/person.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/person.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/person.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/person.js Wed Sep 15 01:40:22 2010
@@ -543,7 +543,7 @@ opensocial.Person.prototype.getDisplayNa
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Person.Field.html"><code>
- * Person.Field</code></a>
+ * Person.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>=}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/phone.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/phone.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/phone.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/phone.js Wed Sep 15 01:40:22 2010
@@ -76,7 +76,7 @@ opensocial.Phone.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Phone.Field.html"><code>
- * Phone.Field</code></a>
+ * Phone.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-reference/url.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-reference/url.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-reference/url.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-reference/url.js Wed Sep 15 01:40:22 2010
@@ -81,7 +81,7 @@ opensocial.Url.Field = {
*
* @param {string} key The key to get data for;
* keys are defined in <a href="opensocial.Url.Field.html"><code>
- * Url.Field</code></a>
+ * Url.Field</code></a>.
* @param {Object.<opensocial.DataRequest.DataRequestFields, Object>}
* opt_params Additional
* <a href="opensocial.DataRequest.DataRequestFields.html">params</a>
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/base.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/base.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/base.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/base.js Wed Sep 15 01:40:22 2010
@@ -99,6 +99,7 @@ os.EMPTY_ARRAY = [];
/**
* Regular expressions
* TODO(levik): Move all regular expressions here.
+ * @private
*/
os.regExps_ = {
ONLY_WHITESPACE: /^[ \t\n]*$/,
@@ -147,6 +148,7 @@ os.compileTemplateString = function(src,
/**
* Render one compiled node with a context.
* @return {Element} a DOM element containing the result of template processing.
+ * @private
*/
os.renderTemplateNode_ = function(compiledNode, context) {
var template = domCloneElement(compiledNode);
@@ -186,6 +188,7 @@ os.createTemplateCustomTag = function(te
* Where multiple elements share a name, the map value will be an array.
* @param {Element} node The node whose children are to be mapped.
* @return {Object} A Map of Element names to Elements.
+ * @private
*/
os.computeChildMap_ = function(node) {
var map = {};
@@ -233,6 +236,7 @@ os.createNodeAccessor_ = function(node)
* A singleton instance of the current gadget Prefs - only instantiated if
* we are in a gadget container.
* @type {gadgets.Prefs}
+ * @private
*/
os.gadgetPrefs_ = null;
if (window['gadgets'] && window['gadgets']['Prefs']) {
@@ -267,6 +271,7 @@ os.customAttributes_ = {};
* @param {string} attrName The name of the custom attribute.
* @param {function(string)} functor A function with signature
* function({Element}, {string}, {Object}, {JSEvalContext}).
+ * @private
*/
os.registerAttribute_ = function(attrName, functor) {
os.customAttributes_[attrName] = functor;
@@ -365,6 +370,7 @@ os.doTag = function(node, ns, tag, data,
/**
* Checks the current context, and if it's an element node, sets it to be used
* for future <os:renderAll/> operations.
+ * @private
*/
os.setContextNode_ = function(data, context) {
if (data.nodeType == DOM_ELEMENT_NODE) {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/compiler.js Wed Sep 15 01:40:22 2010
@@ -112,6 +112,7 @@ os.regExps_.SPLIT_INTO_TOKENS =
* use "<" or ">".
*
* @param {string} src The string snippet to parse.
+ * @private
*/
os.remapOperators_ = function(src) {
return src.replace(os.regExps_.SPLIT_INTO_TOKENS,
@@ -125,6 +126,7 @@ os.remapOperators_ = function(src) {
* Remap variable references in the expression.
* @param {string} expr The expression to transform.
* @return {string} Transformed exression.
+ * @private
*/
os.transformVariables_ = function(expr) {
expr = os.replaceTopLevelVars_(expr);
@@ -134,6 +136,7 @@ os.transformVariables_ = function(expr)
/**
* Map of variables to transform
+ * @private
*/
os.variableMap_ = {
'my': os.VAR_my,
@@ -149,6 +152,7 @@ os.variableMap_ = {
* Replace the top level variables
* @param {string} text The expression.
* @return {string} Expression with replacements.
+ * @private
*/
os.replaceTopLevelVars_ = function(text) {
@@ -177,6 +181,7 @@ os.replaceTopLevelVars_ = function(text)
* for example one that looks up foo -> getFoo() -> get("foo").
*
* TODO: This should not be in compiler.
+ * @private
*/
os.identifierResolver_ = function(data, name) {
return data.hasOwnProperty(name) ? data[name] : ('get' in data ? data.get(name) : null);
@@ -255,6 +260,7 @@ os.getFromContext = function(context, na
* @param {string} expr The expression snippet to parse.
* @param {string=} opt_default An optional default value reference (such as the
* literal string 'null').
+ * @private
*/
os.transformExpression_ = function(expr, opt_default) {
expr = os.remapOperators_(expr);
@@ -269,6 +275,7 @@ os.transformExpression_ = function(expr,
* A Map of special attribute names to change while copying attributes during
* compilation. The key is OST-spec attribute, while the value is JST attribute
* used to implement that feature.
+ * @private
*/
os.attributeMap_ = {
'if': ATT_display,
@@ -278,6 +285,7 @@ os.attributeMap_ = {
/**
* Appends a JSTemplate attribute value while maintaining previous values.
+ * @private
*/
os.appendJSTAttribute_ = function(node, attrName, value) {
var previousValue = node.getAttribute(attrName);
@@ -299,6 +307,7 @@ os.appendJSTAttribute_ = function(node,
* TODO(levik): On IE, some properties/attributes might be case sensitive when
* set through script (such as "colSpan") - since they're not case sensitive
* when defined in HTML, we need to support this type of use.
+ * @private
*/
os.copyAttributes_ = function(from, to, opt_customTag) {
@@ -405,6 +414,7 @@ os.copyAttributes_ = function(from, to,
* are converted into markup recognizable by JSTemplate.
*
* TODO: process text nodes and attributes with ${} notation here
+ * @private
*/
os.compileNode_ = function(node) {
if (node.nodeType == DOM_TEXT_NODE) {
@@ -493,6 +503,7 @@ os.compileNode_ = function(node) {
* "span" otherwise
* @param {Element} element The repeater/conditional element.
* @return {stirng} Name of the node ot represent this repeater.
+ * @private
*/
os.computeContainerTag_ = function(element) {
var child = element.firstChild;
@@ -523,6 +534,7 @@ os.ENTITIES = '<!ENTITY nbsp \" \">
/**
* Creates an HTML node that's a shallow copy of an XML node
* (includes attributes).
+ * @private
*/
os.xmlToHtml_ = function(xmlNode) {
var htmlNode = document.createElement(xmlNode.tagName);
@@ -561,6 +573,7 @@ os.fireCallbacks = function(context) {
*
* @return {boolean} true if node only had text data and needs no further
* processing, false otherwise.
+ * @private
*/
os.processTextContent_ = function(fromNode, toNode) {
if (fromNode.childNodes.length == 1 &&
@@ -596,6 +609,7 @@ os.pushTextNode = function(array, text)
* @param {boolean=} opt_trimEnd Trim the end of the string.
* @return {string} The string with extra spaces removed on IE, original
* string on other browsers.
+ * @private
*/
os.trimWhitespaceForIE_ = function(string, opt_trimStart, opt_trimEnd) {
if (os.isIe) {
@@ -619,6 +633,7 @@ os.trimWhitespaceForIE_ = function(strin
*
* @return {Array.<Node>} An array of textNodes and Span Elements if variable
* substitutions were found, or an empty array if none were.
+ * @private
*/
os.breakTextNode_ = function(textNode) {
var substRex = os.regExps_.VARIABLE_SUBSTITUTION;
@@ -653,6 +668,7 @@ os.breakTextNode_ = function(textNode) {
* - Replaces newlines with spaces.
* - Substitutes variable references for literal semicolons.
* - Addes single quotes around the string.
+ * @private
*/
os.transformLiteral_ = function(string) {
return "'" + string.replace(/'/g, "\\'").
@@ -665,6 +681,7 @@ os.transformLiteral_ = function(string)
*
* @param {string} value Attribute value to parse
* TODO: Rename to parseExpression().
+ * @private
*/
os.parseAttribute_ = function(value) {
if (!value.length) {
@@ -708,6 +725,7 @@ os.parseAttribute_ = function(value) {
* The special value "*" means return all child Nodes.
* @return {string|Element|Object|Array.<Element>} The value as a String,
* Object, Element or array of Elements.
+ * @private
*/
os.getValueFromNode_ = function(node, name) {
@@ -756,6 +774,7 @@ os.getValueFromNode_ = function(node, na
/**
* A map of identifiers that should not be wrapped
* (such as JS built-ins and special method names).
+ * @private
*/
os.identifiersNotToWrap_ = {};
os.identifiersNotToWrap_['true'] = true;
@@ -811,6 +830,7 @@ os.canBeInToken = function(ch) {
* @param {string=} opt_context A string expression to use for context.
* @param {string=} opt_default An optional default value reference (such as the
* literal string 'null').
+ * @private
*/
os.wrapSingleIdentifier = function(iden, opt_context, opt_default) {
if (os.identifiersNotToWrap_.hasOwnProperty(iden) &&
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/container.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/container.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/container.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/container.js Wed Sep 15 01:40:22 2010
@@ -60,16 +60,19 @@ os.Container.domLoaded_ = false;
/**
* @type {number} The number of libraries needed to load.
+ * @private
*/
os.Container.requiredLibraries_ = 0;
/**
* @type {boolean} Determines whether all templates are automatically processed.
+ * @private
*/
os.Container.autoProcess_ = true;
/**
* @type {boolean} Has the document been processed already?
+ * @private
*/
os.Container.processed_ = false;
@@ -391,6 +394,7 @@ os.Container.executeOnDomLoad(os.Contain
/**
* A flag to determine if auto processing is waiting for libraries to load.
* @type {boolean}
+ * @private
*/
os.Container.processWaitingForLibraries_ = false;
@@ -423,6 +427,7 @@ os.Container.executeOnDomLoad(function()
/**
* A handler called when one of the required libraries loads.
+ * @private
*/
os.Container.onLibraryLoad_ = function() {
if (os.Container.requiredLibraries_ > 0) {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jsevalcontext.js Wed Sep 15 01:40:22 2010
@@ -75,6 +75,7 @@ function JsEvalContext(opt_data, opt_par
* variables are inherited. Normally the context object of the parent
* context is the object whose property the parent object is. Null for the
* context of the root object.
+ * @private
*/
JsEvalContext.prototype.constructor_ = function(opt_data, opt_parent) {
var me = this;
@@ -146,6 +147,7 @@ JsEvalContext.prototype.constructor_ = f
* A map of globally defined symbols. Every instance of JsExprContext
* inherits them in its vars_.
* @type {Object}
+ * @private
*/
JsEvalContext.globals_ = {};
@@ -176,6 +178,7 @@ JsEvalContext.setGlobal(GLOB_default, nu
* A cache to reuse JsEvalContext instances. (IE6 perf)
*
* @type {Array.<JsEvalContext>}
+ * @private
*/
JsEvalContext.recycledInstances_ = [];
@@ -323,6 +326,7 @@ var STRING_with = 'with (a_) with (b_) r
/**
* Cache for jsEvalToFunction results.
* @type {Object}
+ * @private
*/
JsEvalContext.evalToFunctionCache_ = {};
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js Wed Sep 15 01:40:22 2010
@@ -138,6 +138,7 @@ function JstProcessor() {
* An array of logging messages. These are collected during processing
* and dumped to the console at the end.
* @type {Array.<string>}
+ * @private
*/
this.logs_ = [];
}
@@ -151,6 +152,7 @@ function JstProcessor() {
* suvives cloneNode() and thus cloned template nodes can share the
* same cache entry.
* @type {number}
+ * @private
*/
JstProcessor.jstid_ = 0;
@@ -158,6 +160,7 @@ JstProcessor.jstid_ = 0;
/**
* Map from jstid to processed js attributes.
* @type {Object}
+ * @private
*/
JstProcessor.jstcache_ = {};
@@ -183,6 +186,7 @@ JstProcessor.jstcache_[0] = {};
* values. (For example when two different nodes in a template share the same
* JST attributes.)
* @type {Object}
+ * @private
*/
JstProcessor.jstcacheattributes_ = {};
@@ -191,6 +195,7 @@ JstProcessor.jstcacheattributes_ = {};
* Map for storing temporary attribute values in prepareNode_() so they don't
* have to be retrieved twice. (IE6 perf)
* @type {Object}
+ * @private
*/
JstProcessor.attributeValues_ = {};
@@ -200,6 +205,7 @@ JstProcessor.attributeValues_ = {};
* The array is global since it can be reused - this way there is no need to
* construct a new array object for each invocation. (IE6 perf)
* @type {Array}
+ * @private
*/
JstProcessor.attributeList_ = [];
@@ -208,6 +214,7 @@ JstProcessor.attributeList_ = [];
* Prepares the template: preprocesses all jstemplate attributes.
*
* @param {Element} template
+ * @private
*/
JstProcessor.prepareTemplate_ = function(template) {
if (!template[PROP_jstcache]) {
@@ -247,6 +254,7 @@ var JST_ATTRIBUTES = [
* @return {Object} The jstcache entry. The processed jst attributes
* are properties of this object. If the node has no jst attributes,
* returns an object with no properties (the jscache_[0] entry).
+ * @private
*/
JstProcessor.prepareNode_ = function(node) {
// If the node already has a cache property, return it.
@@ -338,6 +346,7 @@ JstProcessor.prepareNode_ = function(nod
* (which will be called serially), typically due to a loop structure.
*
* @param {Function} f The first function to run.
+ * @private
*/
JstProcessor.prototype.run_ = function(f) {
var me = this;
@@ -401,6 +410,7 @@ JstProcessor.prototype.run_ = function(f
*
* @param {Array} args Array of method calls structured as
* [ method, arg1, arg2, method, arg1, arg2, ... ].
+ * @private
*/
JstProcessor.prototype.push_ = function(args) {
this.calls_.push(args);
@@ -418,7 +428,9 @@ JstProcessor.prototype.setDebugging = fu
}
};
-
+/**
+ * @private
+ */
JstProcessor.prototype.createArray_ = function() {
if (this.arrayPool_.length) {
return this.arrayPool_.pop();
@@ -428,6 +440,9 @@ JstProcessor.prototype.createArray_ = fu
};
+/**
+ * @private
+ */
JstProcessor.prototype.recycleArray_ = function(array) {
arrayClear(array);
this.arrayPool_.push(array);
@@ -447,6 +462,7 @@ JstProcessor.prototype.recycleArray_ = f
* @param {JsEvalContext} context
*
* @param {Element} template
+ * @private
*/
JstProcessor.prototype.jstProcessOuter_ = function(context, template) {
var me = this;
@@ -490,6 +506,7 @@ JstProcessor.prototype.jstProcessOuter_
* @param {JsEvalContext} context
*
* @param {Element} template
+ * @private
*/
JstProcessor.prototype.jstProcessInner_ = function(context, template) {
var me = this;
@@ -604,6 +621,7 @@ JstProcessor.prototype.jstProcessInner_
*
* @notypecheck FIXME(hmitchell): See OCL6434950. instance and value need
* type checks.
+ * @private
*/
JstProcessor.prototype.jstSelect_ = function(context, template, select) {
var me = this;
@@ -730,6 +748,7 @@ JstProcessor.prototype.jstSelect_ = func
* function that can be passed to jsexec() for evaluation in the
* current jscontext, and the first element is the variable name that
* the value returned by jsexec is assigned to.
+ * @private
*/
JstProcessor.prototype.jstVars_ = function(context, template, values) {
for (var i = 0, I = jsLength(values); i < I; i += 2) {
@@ -758,6 +777,7 @@ JstProcessor.prototype.jstVars_ = functi
* function that can be passed to jsexec() for evaluation in the
* current jscontext, and the first element is the label that
* determines where the value returned by jsexec is assigned to.
+ * @private
*/
JstProcessor.prototype.jstValues_ = function(context, template, values) {
for (var i = 0, I = jsLength(values); i < I; i += 2) {
@@ -819,6 +839,7 @@ JstProcessor.prototype.jstValues_ = func
*
* @param {Function} content Processed value of the jscontent
* attribute.
+ * @private
*/
JstProcessor.prototype.jstContent_ = function(context, template, content) {
// NOTE: Profiling shows that this method costs significant
@@ -848,6 +869,7 @@ JstProcessor.prototype.jstContent_ = fun
*
* @return {Object} A javascript object that has all js template
* processing attribute values of the node as properties.
+ * @private
*/
JstProcessor.prototype.jstAttributes_ = function(template) {
if (template[PROP_jstcache]) {
@@ -1001,6 +1023,7 @@ function jstSetInstance(template, values
* @param {string} caller An identifier for the caller of .log_.
* @param {Element} template The template node being processed.
* @param {Object} jstAttributeValues The jst attributes of the template node.
+ * @private
*/
JstProcessor.prototype.logState_ = function(
caller, template, jstAttributeValues) {
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/jsTemplate/util.js Wed Sep 15 01:40:22 2010
@@ -233,6 +233,7 @@ DomTraverser.prototype.run = function(ro
/**
* Processes a single node.
* @param {Element} node The current node of the traversal.
+ * @private
*/
DomTraverser.prototype.process_ = function(node) {
var me = this;
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/loader.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/loader.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/loader.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/loader.js Wed Sep 15 01:40:22 2010
@@ -53,6 +53,7 @@ os.Loader = {};
/**
* A map of URLs which were already loaded.
+ * @private
*/
os.Loader.loadedUrls_ = {};
@@ -76,6 +77,7 @@ os.Loader.loadUrl = function(url, callba
* the same URL twice.
* @param {string} url The URL of the Template Library.
* @param {Function} callback Function to call once loaded.
+ * @private
*/
os.Loader.requestUrlXHR_ = function(url, callback) {
if (os.Loader.loadedUrls_[url]) {
@@ -107,6 +109,7 @@ os.Loader.requestUrlXHR_ = function(url,
* @param {string} url The URL where the content is located.
* @param {Function} callback Function to call with the data from the URL
* once it is fetched.
+ * @private
*/
os.Loader.requestUrlGadgets_ = function(url, callback) {
var params = {};
@@ -155,6 +158,7 @@ os.Loader.loadContent = function(xmlStri
* Gets the function that should be used for processing a tag.
* @param {string} tagName Name of the tag.
* @return {?Function} The function for processing such tags.
+ * @private
*/
os.Loader.getProcessorFunction_ = function(tagName) {
// TODO(levik): This won't work once compiler does name mangling.
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/os.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/os.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/os.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/os.js Wed Sep 15 01:40:22 2010
@@ -131,7 +131,7 @@ os.defineBuiltinTags();
* @param {Object} object The object in the scope of which to get a named
* property.
* @param {string} name The name of the property to get.
- * @return {Object?|undefined} The property requested.
+ * @return {Object?} The property requested.
*/
os.resolveOpenSocialIdentifier = function(object, name) {
// Simple property from object.
Modified: shindig/trunk/features/src/main/javascript/features/opensocial-templates/template.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/opensocial-templates/template.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/opensocial-templates/template.js (original)
+++ shindig/trunk/features/src/main/javascript/features/opensocial-templates/template.js Wed Sep 15 01:40:22 2010
@@ -115,6 +115,7 @@ os.getTemplate = function(templateId) {
/**
* Sets a single compiled node into this template.
* @param {Element} node - A compiled node.
+ * @private
*/
os.Template.prototype.setCompiledNode_ = function(node) {
os.removeChildren(this.templateRoot_);
@@ -124,6 +125,7 @@ os.Template.prototype.setCompiledNode_ =
/**
* Sets a list of compiled nodes into this template.
* @param {Array.<Element>} nodes An array of compiled nodes.
+ * @private
*/
os.Template.prototype.setCompiledNodes_ = function(nodes) {
os.removeChildren(this.templateRoot_);
Modified: shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js (original)
+++ shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js Wed Sep 15 01:40:22 2010
@@ -29,8 +29,7 @@ if (gadgets && gadgets.rpc) { //Only def
/**
* Dispatch a JSON-RPC batch request to services defined in the osapi namespace
- * @param callbackId
- * @param requests
+ * @param {Array} requests
*/
osapi._handleGadgetRpcMethod = function(requests) {
var responses = new Array(requests.length);
@@ -73,13 +72,14 @@ if (gadgets && gadgets.rpc) { //Only def
}
};
+ osapi.container = {};
+
/**
* Basic implementation of system.listMethods which can be used to introspect
* available services
* @param request
* @param callback
*/
- osapi.container = {};
osapi.container['listMethods'] = function(request, callback) {
var names = [];
recurseNames(osapi, '', 5, names);
Modified: shindig/trunk/features/src/main/javascript/features/shindig.container/shindig-container.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/shindig.container/shindig-container.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/shindig.container/shindig-container.js (original)
+++ shindig/trunk/features/src/main/javascript/features/shindig.container/shindig-container.js Wed Sep 15 01:40:22 2010
@@ -263,10 +263,9 @@ shindig.IfrGadgetService.prototype.reque
* real containers.
* TODO: Find a better default for this function
*
- * @param view The view name to get the url for.
+ * @param {string} view The view name to get the url for.
*/
-shindig.IfrGadgetService.prototype.getUrlForView = function(
- view) {
+shindig.IfrGadgetService.prototype.getUrlForView = function(view) {
if (view === 'canvas') {
return '/canvas';
} else if (view === 'profile') {
Modified: shindig/trunk/features/src/main/javascript/features/views/views.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/views/views.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/views/views.js (original)
+++ shindig/trunk/features/src/main/javascript/features/views/views.js Wed Sep 15 01:40:22 2010
@@ -184,15 +184,15 @@ gadgets.views = function() {
}
function objectIsEmpty(v) {
- if ((typeof v === 'object') || (typeof v === 'function')) {
- for (var i in v) {
- if (v.hasOwnProperty(i)) {
- return false;
- }
- }
- return true;
- }
- return false;
+ if ((typeof v === 'object') || (typeof v === 'function')) {
+ for (var i in v) {
+ if (v.hasOwnProperty(i)) {
+ return false;
+ }
+ }
+ return true;
+ }
+ return false;
}
while ((group = expansionRE.exec(urlTemplate))) {
@@ -230,8 +230,8 @@ gadgets.views = function() {
for (var i in v) {
if (v.hasOwnProperty(i)) {
j.push(i + '=' + v[i]);
- }
- }
+ }
+ }
}
}).join(arg));
break;
Modified: shindig/trunk/features/src/main/javascript/features/xmlutil/xmlutil.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/xmlutil/xmlutil.js?rev=997164&r1=997163&r2=997164&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/xmlutil/xmlutil.js (original)
+++ shindig/trunk/features/src/main/javascript/features/xmlutil/xmlutil.js Wed Sep 15 01:40:22 2010
@@ -23,6 +23,7 @@ opensocial.xmlutil = opensocial.xmlutil
/**
* Cached DOMParser objects on browsers that support it.
+ * @private
*/
opensocial.xmlutil.parser_ = null;
@@ -87,7 +88,9 @@ opensocial.xmlutil.getRequiredNamespaces
return opensocial.xmlutil.serializeNamespaces_(namespaces);
};
-
+/**
+ * @private
+ */
opensocial.xmlutil.serializeNamespaces_ = function(namespaces) {
var buffer = [];
for (var prefix in namespaces) {
@@ -103,7 +106,8 @@ opensocial.xmlutil.serializeNamespaces_
* Returns a map of XML namespaces declared on an DOM Element.
* @param {Element} el The Element to inspect.
* @return {Object.<string, string>} A Map of keyed by prefix of declared
- * namespaces.
+ * namespaces.
+ * @private
*/
opensocial.xmlutil.getNamespaceDeclarations_ = function(el) {
var namespaces = {};