You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/31 23:40:39 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
HeartSaVioR opened a new pull request #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086
### What changes were proposed in this pull request?
This patch proposes to cache Class instance for the UDF instance in HiveFunctionWrapper to fix the case where Hive simple UDF is somehow transformed (expression is copied) and evaluated later with another classloader (for the case current thread context classloader is somehow changed). In this case, Spark throws CNFE as of now.
It's only occurred for Hive simple UDF, as HiveFunctionWrapper caches the UDF instance whereas it doesn't do for `UDF` type. The comment says Spark has to create instance every time for UDF, so we cannot simply do the same. This patch caches Class instance instead, and switch current thread context classloader to which loads the Class instance.
This patch extends the test boundary as well. We only tested with GenericUDTF for SPARK-26560, and this patch actually requires only UDF. But to avoid regression for other types as well, this patch adds all available types (UDF, GenericUDF, AbstractGenericUDAFResolver, UDAF, GenericUDTF) into the boundary of tests.
Credit to @cloud-fan as he discovered the problem and proposed the solution.
### Why are the changes needed?
Above section describes why it's a bug and how it's fixed.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
New UTs added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606945439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25354/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606945434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-607013918
Thanks for the quick review and merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606957043
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25355/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606948400
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4]
Cache Class instance for the UDF instance in HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606948383
**[Test build #120655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120655/testReport)** for PR 28086 at commit [`b515c69`](https://github.com/apache/spark/commit/b515c696799ac576bbd060a811ba2234506a2d38).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4]
Cache Class instance for the UDF instance in HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606944996
**[Test build #120655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120655/testReport)** for PR 28086 at commit [`b515c69`](https://github.com/apache/spark/commit/b515c696799ac576bbd060a811ba2234506a2d38).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606957035
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606956682
**[Test build #120656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120656/testReport)** for PR 28086 at commit [`eb42ff1`](https://github.com/apache/spark/commit/eb42ff155f220cdf8bb391160d51257bd231b222).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606948405
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120655/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606991313
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606948400
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606948405
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120655/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-607009137
thanks, merging to 2.4!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606945434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4]
Cache Class instance for the UDF instance in HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606956682
**[Test build #120656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120656/testReport)** for PR 28086 at commit [`eb42ff1`](https://github.com/apache/spark/commit/eb42ff155f220cdf8bb391160d51257bd231b222).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606957035
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606957043
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25355/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606991313
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606945439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25354/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606991317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120656/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR edited a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
HeartSaVioR edited a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606955822
To reduce the code divergence I just enabled language feature (as compiler guided on error message). There seems to be the way we don't enable it (simply use AnyRef instead of wildcard) so that's up to our preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606955822
To reduce the code divergence I just enabled language feature. There seems to be the way we don't enable it (simply use AnyRef instead of wildcard) so that's up to our preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4]
Cache Class instance for the UDF instance in HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606990931
**[Test build #120656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120656/testReport)** for PR 28086 at commit [`eb42ff1`](https://github.com/apache/spark/commit/eb42ff155f220cdf8bb391160d51257bd231b222).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606991317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120656/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28086:
[SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in
HiveFunctionWrapper
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28086: [SPARK-31312][SQL][2.4] Cache Class instance for the UDF instance in HiveFunctionWrapper
URL: https://github.com/apache/spark/pull/28086#issuecomment-606944996
**[Test build #120655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120655/testReport)** for PR 28086 at commit [`b515c69`](https://github.com/apache/spark/commit/b515c696799ac576bbd060a811ba2234506a2d38).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org