You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/09 08:57:15 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files
iverase opened a new pull request #2331:
URL: https://github.com/apache/lucene-solr/pull/2331
While trying to add a Base test class for Vector based on `BaseIndexFileFormatTestCase`, a bug surface on the Lucene90VectorWriter constructor. If there is an exception if the middle, it might happen that files are not properly closed and therefore a leak.
Here is the proposal, move the current `TestVectorValues` to a `BaseVectorFormatTestCase` which extends `BaseIndexFileFormatTestCase`.
Fix the constructor so it handle closing files on error properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase merged pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #2331:
URL: https://github.com/apache/lucene-solr/pull/2331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files
Posted by GitBox <gi...@apache.org>.
zacharymorn commented on pull request #2331:
URL: https://github.com/apache/lucene-solr/pull/2331#issuecomment-777222542
Hi,
I was looking into https://issues.apache.org/jira/browse/LUCENE-9639 earlier and had the same thought of `BaseVectorFormatTestCase` seems to be missing, which led me to do some search and found this PR. I'm wondering if unit test for `SimpleTextVectorFormat` could be added as part of this PR as well since it appears to be a small change? If it's better to keep this PR focused, I'm willing to pick that up and submit a PR once this one has merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #2331:
URL: https://github.com/apache/lucene-solr/pull/2331#issuecomment-777254707
@zacharymorn I think we can open another PR for the change you are proposing. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org