You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "bwangelme (via GitHub)" <gi...@apache.org> on 2023/09/04 11:34:06 UTC
[GitHub] [thrift] bwangelme opened a new pull request, #2853: fix: fix golang NewTSocketConf comment error
bwangelme opened a new pull request, #2853:
URL: https://github.com/apache/thrift/pull/2853
Client: ["go"]
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy merged pull request #2853: fix: fix golang NewTSocketConf comment error
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy merged PR #2853:
URL: https://github.com/apache/thrift/pull/2853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2853: fix: fix golang NewTSocketConf comment error
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2853:
URL: https://github.com/apache/thrift/pull/2853#issuecomment-1709544846
Not two minutes ago. Then I looked it up and found a) two more places with a similar comment and b) no indication that your change is even correct. So now I have questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] bwangelme commented on pull request #2853: fix: fix golang NewTSocketConf comment error
Posted by "bwangelme (via GitHub)" <gi...@apache.org>.
bwangelme commented on PR #2853:
URL: https://github.com/apache/thrift/pull/2853#issuecomment-1709478680
@Jens-G
Hello, Is there any question on my PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org