[GitHub] [cloudstack] server24 commented on issue #3497: VMs stuck in Stopping state due to NPE at org.apache.cloudstack.network.topology.BasicNetworkVisitor.visit(BasicNetworkVisitor.java:201)

[GitBox <gi...@apache.org>]

server24 commented on issue #3497: VMs stuck in Stopping state due to NPE at org.apache.cloudstack.network.topology.BasicNetworkVisitor.visit(BasicNetworkVisitor.java:201)
URL: https://github.com/apache/cloudstack/issues/3497#issuecomment-512237707
 
 
   Line 201 of BasicNetworkVisitor.java in CS 4.11.3 is:
   `        if (router.getPodIdToDeployIn().longValue() == destination.getPod().getId()) {`
   
   in this method:
   ```
       @Override
       public boolean visit(final DhcpEntryRules dhcp) throws ResourceUnavailableException {
           final VirtualRouter router = dhcp.getRouter();
   
           final Commands commands = new Commands(Command.OnError.Stop);
           final NicVO nicVo = dhcp.getNicVo();
           final UserVmVO userVM = dhcp.getUserVM();
           final DeployDestination destination = dhcp.getDestination();
           final boolean remove = dhcp.isRemove();
   
           **if (router.getPodIdToDeployIn().longValue() == destination.getPod().getId()) {**
               _commandSetupHelper.createDhcpEntryCommand(router, userVM, nicVo, remove, commands);
   
               return _networkGeneralHelper.sendCommandsToRouter(router, commands);
           }
           return true;
       }
   ```
   
   This works fine in advanced network, but seems to fail with a basic network; also all tests in the relative merge pull seem to be done with advanced networking only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services