[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #10: Find libpulsarwithdeps.a when LINK_STATIC is ON

[GitBox <gi...@apache.org>]

BewareMyPower commented on PR #10:
URL: https://github.com/apache/pulsar-client-python/pull/10#issuecomment-1275531698

   Since the C++ client doesn't have an official macOS release, this PR cannot be verified by CI, unless building the C++ client in the workflow, which is unaccepted, see https://github.com/apache/pulsar-client-python/pull/3#pullrequestreview-1125581221
   
   >  Instead we should just fetch the binaries that are already available (eg: RPM, Deb, APK, etc.. ). (Homebrew is a bit a of an exception since it's not statically linked).
   
   This CMakeLists.txt has been verified in the C++ library built with the script in https://github.com/apache/pulsar-client-cpp/pull/38
   
   ```bash
   $ otool -L _pulsar.so 
   _pulsar.so:
   	@rpath/_pulsar.so (compatibility version 0.0.0, current version 0.0.0)
   	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1858.112.0)
   	/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1163.100.19)
   	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
   	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)
   	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0)
   $ python3 -c 'import _pulsar'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org