You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by to...@apache.org on 2022/05/06 21:12:53 UTC
[libcloud] branch trunk updated (b1e40057c -> 870f14032)
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
from b1e40057c Upgrade black.
new 5b15d6191 Fix crash on missing etag in s3 driver
new 15e1d95ac Formatting
new 5acbf4ba1 Supply reason for pytest exit
new 9c6f7842e Merge branch 'RunOrVeith-fix-missing-etag' into trunk
new 870f14032 Add changelog entry.
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.rst | 11 +++++++++++
libcloud/storage/drivers/s3.py | 7 +++++--
libcloud/test/conftest.py | 4 ++--
3 files changed, 18 insertions(+), 4 deletions(-)
[libcloud] 03/05: Supply reason for pytest exit
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 5acbf4ba110be62b4842222cfada8b48fb3c7d51
Author: Veith Röthlingshöfer <ve...@understand.ai>
AuthorDate: Thu May 5 15:32:38 2022 +0200
Supply reason for pytest exit
---
libcloud/test/conftest.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcloud/test/conftest.py b/libcloud/test/conftest.py
index 53b941c6e..c0a73bfd8 100644
--- a/libcloud/test/conftest.py
+++ b/libcloud/test/conftest.py
@@ -28,7 +28,7 @@ def pytest_configure(config):
print("Missing " + secrets_current)
print("Maybe you forgot to copy it from -dist:")
print("cp libcloud/test/secrets.py-dist libcloud/test/secrets.py")
- pytest.exit("")
+ pytest.exit(reason="Secrets file missing")
mtime_current = os.path.getmtime(secrets_current)
mtime_dist = os.path.getmtime(secrets_dist)
@@ -39,4 +39,4 @@ def pytest_configure(config):
"Please copy the new secrets.py-dist file over otherwise"
+ " tests might fail"
)
- pytest.exit("")
+ pytest.exit(reason="Secrets file out of date")
[libcloud] 01/05: Fix crash on missing etag in s3 driver
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 5b15d61918ccc60c438cb1dde88fae2554c94455
Author: Veith Röthlingshöfer <ve...@understand.ai>
AuthorDate: Thu May 5 15:25:01 2022 +0200
Fix crash on missing etag in s3 driver
---
libcloud/storage/drivers/s3.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libcloud/storage/drivers/s3.py b/libcloud/storage/drivers/s3.py
index d52630105..9973bdbd1 100644
--- a/libcloud/storage/drivers/s3.py
+++ b/libcloud/storage/drivers/s3.py
@@ -1192,8 +1192,10 @@ class BaseS3StorageDriver(StorageDriver):
return content_length
def _headers_to_object(self, object_name, container, headers):
- hash = headers["etag"].replace('"', "")
- extra = {"content_type": headers["content-type"], "etag": headers["etag"]}
+ hash = headers.get("etag", "").replace('"', "")
+ extra = {"content_type": headers["content-type"]}
+ if "etag" in headers:
+ extra["etag"] = headers["etag"]
meta_data = {}
if "content-encoding" in headers:
[libcloud] 05/05: Add changelog entry.
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 870f140321445b5fd991da71ac3746f6298c6bfc
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri May 6 23:04:41 2022 +0200
Add changelog entry.
---
CHANGES.rst | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/CHANGES.rst b/CHANGES.rst
index 5a57f57a1..8925c6915 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -23,6 +23,17 @@ Compute
(GITHUB-1661, GITHUB-1661)
[Dimitris Galanis - @dimgal1]
+Storage
+~~~~~~~
+
+- [Google Storage] Fix public objects retrieval. In some scenarios, Google
+ doesn't return ``etag`` header in the response (e.g. for gzip content
+ encoding). The code has been updated to take this into account and not
+ throw if the header is not present.
+
+ (GITHUB-1682, GITHUB-1683)
+ [Veith Röthlingshöfer - @RunOrVeith]
+
Changes in Apache Libcloud 3.5.0
--------------------------------
[libcloud] 04/05: Merge branch 'RunOrVeith-fix-missing-etag' into trunk
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 9c6f7842ec8ca0f14432594822485dc93e7ce137
Merge: b1e40057c 5acbf4ba1
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri May 6 23:02:02 2022 +0200
Merge branch 'RunOrVeith-fix-missing-etag' into trunk
libcloud/storage/drivers/s3.py | 7 +++++--
libcloud/test/conftest.py | 4 ++--
2 files changed, 7 insertions(+), 4 deletions(-)
[libcloud] 02/05: Formatting
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git
commit 15e1d95ac03d0ade35f48203d031a32e46241859
Author: Veith Röthlingshöfer <ve...@understand.ai>
AuthorDate: Thu May 5 15:32:25 2022 +0200
Formatting
---
libcloud/storage/drivers/s3.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/libcloud/storage/drivers/s3.py b/libcloud/storage/drivers/s3.py
index 9973bdbd1..50fdc20d5 100644
--- a/libcloud/storage/drivers/s3.py
+++ b/libcloud/storage/drivers/s3.py
@@ -1196,6 +1196,7 @@ class BaseS3StorageDriver(StorageDriver):
extra = {"content_type": headers["content-type"]}
if "etag" in headers:
extra["etag"] = headers["etag"]
+
meta_data = {}
if "content-encoding" in headers: