You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Näslund <da...@longitudo.com> on 2010/04/26 20:53:04 UTC
[PATCH] Converter for svn_wc_status3_t to svn_wc_status2_t
Hi!
Since I can't test it, and know too little of libsvn_wc, I ask if
any of you guys think it looks ok?
[[[
Implmenent converter function for converting svn_wc_status3_t to
svn_wc_status2_t.
* subversion/include/private/svn_wc_private.h
(svn_wc__status2_from_3): Return svn_error_t * instead of
svn_wc_status2_t *. Return the new status in an out parameter
instead. I needed to be able to return errors from the entry
fetching function. Add wc_ctx and local_abspath parameters to be
used when fetching the entry.
* subversion/libsvn_wc/deprecated.c
(status_4_wrapper_baton): Add wc_ctx field to be used when calling
svn_wc__status2_from_3().
(status4_wrapper_func): Track parameter and return value changes of
svn_wc__status2_from_3().
(svn_wc_get_status_editor4): Initialize wc_ctx field of the
wrapper_baton.
(svn_wc_status2): Track parameter and return value changes of
svn_wc__status2_from_3().
* subversion/libsvn_wc/util.c
(svn_wc__status2_from_3): Initialize the svn_wc_status2_t struct with
values from svn_wc_status3_t.
* subversion/libsvn_client/deprecated.c
(status4_wrapper_baton): Add ctx field.
(status4_wrapper_func): Track parameter and return value changes of
svn_wc__status2_from_3().
(svn_client_status4): Initialize ctx field of wrapper_baton.
]]]
Re: [PATCH] Converter for svn_wc_status3_t to svn_wc_status2_t
Posted by Daniel Näslund <da...@longitudo.com>.
On Mon, Apr 26, 2010 at 10:53:04PM +0200, Daniel Näslund wrote:
>
> [[[
> Implmenent converter function for converting svn_wc_status3_t to
> svn_wc_status2_t.
>
> * subversion/include/private/svn_wc_private.h
> (svn_wc__status2_from_3): Return svn_error_t * instead of
> svn_wc_status2_t *. Return the new status in an out parameter
> instead. I needed to be able to return errors from the entry
> fetching function. Add wc_ctx and local_abspath parameters to be
> used when fetching the entry.
>
> * subversion/libsvn_wc/deprecated.c
> (status_4_wrapper_baton): Add wc_ctx field to be used when calling
> svn_wc__status2_from_3().
> (status4_wrapper_func): Track parameter and return value changes of
> svn_wc__status2_from_3().
> (svn_wc_get_status_editor4): Initialize wc_ctx field of the
> wrapper_baton.
> (svn_wc_status2): Track parameter and return value changes of
> svn_wc__status2_from_3().
>
> * subversion/libsvn_wc/util.c
> (svn_wc__status2_from_3): Initialize the svn_wc_status2_t struct with
> values from svn_wc_status3_t.
>
> * subversion/libsvn_client/deprecated.c
> (status4_wrapper_baton): Add ctx field.
> (status4_wrapper_func): Track parameter and return value changes of
> svn_wc__status2_from_3().
> (svn_client_status4): Initialize ctx field of wrapper_baton.
> ]]]
Committed with tweaks suggested by gstein in r938246.
Re: [PATCH] Converter for svn_wc_status3_t to svn_wc_status2_t
Posted by Daniel Näslund <da...@longitudo.com>.
On Mon, Apr 26, 2010 at 10:53:04PM +0200, Daniel Näslund wrote:
>
> [[[
> Implmenent converter function for converting svn_wc_status3_t to
> svn_wc_status2_t.
>
> * subversion/include/private/svn_wc_private.h
> (svn_wc__status2_from_3): Return svn_error_t * instead of
> svn_wc_status2_t *. Return the new status in an out parameter
> instead. I needed to be able to return errors from the entry
> fetching function. Add wc_ctx and local_abspath parameters to be
> used when fetching the entry.
>
> * subversion/libsvn_wc/deprecated.c
> (status_4_wrapper_baton): Add wc_ctx field to be used when calling
> svn_wc__status2_from_3().
> (status4_wrapper_func): Track parameter and return value changes of
> svn_wc__status2_from_3().
> (svn_wc_get_status_editor4): Initialize wc_ctx field of the
> wrapper_baton.
> (svn_wc_status2): Track parameter and return value changes of
> svn_wc__status2_from_3().
>
> * subversion/libsvn_wc/util.c
> (svn_wc__status2_from_3): Initialize the svn_wc_status2_t struct with
> values from svn_wc_status3_t.
>
> * subversion/libsvn_client/deprecated.c
> (status4_wrapper_baton): Add ctx field.
> (status4_wrapper_func): Track parameter and return value changes of
> svn_wc__status2_from_3().
> (svn_client_status4): Initialize ctx field of wrapper_baton.
> ]]]
Committed with tweaks suggested by gstein in r938246.