You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "imply-cheddar (via GitHub)" <gi...@apache.org> on 2023/06/22 02:25:33 UTC
[GitHub] [druid] imply-cheddar opened a new pull request, #14466: Fix compatibility issue with SqlTaskResource
imply-cheddar opened a new pull request, #14466:
URL: https://github.com/apache/druid/pull/14466
The `DruidException` changes broke the response format for errors coming back from the `SqlTaskResource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cheddar commented on pull request #14466: Fix compatibility issue with SqlTaskResource
Posted by "cheddar (via GitHub)" <gi...@apache.org>.
cheddar commented on PR #14466:
URL: https://github.com/apache/druid/pull/14466#issuecomment-1603905986
The other_modules tests are complaining because the SqlTaskResource apparently never had tests put on it, so there's no coverage. This PR is just fixing the known compatibility issue and not fixing the fact that tests were never actually created to help catch such issues in the first place.
There also appears to be a flakey test in processing around HttpConfig. I've seen it pass and fail multiple times over now, I do not know why, but the CI has been pretty flakey with this PR and fighting with it to get clean green checks is just going to waste energy. So I'm going to merge as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cheddar merged pull request #14466: Fix compatibility issue with SqlTaskResource
Posted by "cheddar (via GitHub)" <gi...@apache.org>.
cheddar merged PR #14466:
URL: https://github.com/apache/druid/pull/14466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org