[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

[GitBox <gi...@apache.org>]

slfan1989 commented on code in PR #5055:
URL: https://github.com/apache/hadoop/pull/5055#discussion_r1003668749


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptorRetry.java:
##########
@@ -150,8 +150,8 @@ protected YarnConfiguration createConfiguration() {
         mockPassThroughInterceptorClass + "," + mockPassThroughInterceptorClass
             + "," + TestableFederationClientInterceptor.class.getName());
 
-    conf.set(YarnConfiguration.FEDERATION_POLICY_MANAGER,
-        UniformBroadcastPolicyManager.class.getName());

Review Comment:
   Thank you very much for helping to review the code!
   
   `UniformBroadcastPolicyManager ` is the default policy, 
    if we do not set yarn.federation.policy-manager, We will use `UniformBroadcastPolicyManager` by default. 
   
   `TestFederationClientInterceptor` will use `UniformBroadcastPolicyManager`.
   
   I will modify the unit test code so that TestFederationClientInterceptorRetry overrides both `TestSequentialBroadcastPolicyManager`, `UniformBroadcastPolicyManager`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org