[GitHub] williaster commented on a change in pull request #5218: [fix] layout converter fix

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5218: [fix] layout converter fix
URL: https://github.com/apache/incubator-superset/pull/5218#discussion_r197236078
 
 

 ##########
 File path: superset/assets/spec/javascripts/dashboard/fixtures.jsx
 ##########
 @@ -169,3 +169,141 @@ export const {
   datasources: {},
   user_id: '1',
 });
+
+export const mockSliceEntities = {
 
 Review comment:
   @graceguo-supercat can we actually delete this file? all of the fixtures for the new dashboard are within `spec/javascripts/dashboard/fixtures/` and are separated by type (not all in one file). there's actually one for `mockSliceEntities` but you could add to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org