[GitHub] [incubator-kyuubi] bowenliang123 commented on a diff in pull request #3308: [KYUUBI #3300] [Authz] Support overriding usergroup with UserStore in AccessRequest

[GitBox <gi...@apache.org>]

bowenliang123 commented on code in PR #3308:
URL: https://github.com/apache/incubator-kyuubi/pull/3308#discussion_r1040299932


##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerLocalClient.scala:
##########
@@ -45,6 +48,24 @@ class RangerLocalClient extends RangerAdminRESTClient with RangerClientHelper {
       lastKnownVersion: Long): ServicePolicies = {
     policies
   }
+
+  override def getUserStoreIfUpdated(

Review Comment:
   `RangerLocalClient` is put in `ranger-spark-security.xml` as implementation of `RangerAdminRESTClient` interface, and it must override `getUserStoreIfUpdated` for Ranger 2.1+ but it will comes to error while overriding nothing for Ranger 2.0 and below.
   
   I have difficulty in shim the version difference. What shall we do here? Make authz support 2.1+ only, or just remove support this use case ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org