You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/23 04:07:01 UTC

[GitHub] [cloudstack] hooklee2000 opened a new pull request, #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

hooklee2000 opened a new pull request, #6489:
URL: https://github.com/apache/cloudstack/pull/6489

   Description
   Types of changes
   
   when catched error, we changed message.success.add.vpn.customer.gateway to
   message.add.vpn.customer.gateway.failed.
   
       Bug fix (non-breaking change which fixes an issue)
   
   Feature/Enhancement Scale or Bug Severity
   Bug Severity
   
   Minor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1163914808

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6489 (SL-JID-1817)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1164071700

   @hooklee2000 can you change the base branch of the PR to 4.17 and rebase your PR branch to the 4.17 branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] hooklee2000 commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
hooklee2000 commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1165072291

   Closed by a new pr #6493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1163904651

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1163904196

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1163903781

   Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
   Here are some useful points:
   - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
   - Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
   - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
   - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
   - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
   Apache CloudStack is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
   Slack: https://apachecloudstack.slack.com/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6489:
URL: https://github.com/apache/cloudstack/pull/6489#issuecomment-1163904657

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] hooklee2000 closed pull request #6489: UI fix message.add.vpn.customer.gateway.failed when catched error

Posted by GitBox <gi...@apache.org>.
hooklee2000 closed pull request #6489: UI fix  message.add.vpn.customer.gateway.failed when catched error
URL: https://github.com/apache/cloudstack/pull/6489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org