You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2011/11/01 21:41:00 UTC

Review Request: Refactor MasterTest.* to use a test fixture

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2664/
-----------------------------------------------------------

Review request for mesos.


Summary
-------

This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.

[This is just an import of the diff in the JIRA issue into reviewboard.]


This addresses bug MESOS-46.
    https://issues.apache.org/jira/browse/MESOS-46


Diffs
-----

  src/tests/master_tests.cpp 2438114 

Diff: https://reviews.apache.org/r/2664/diff


Testing
-------


Thanks,

Charles

Re: Review Request: Refactor MasterTest.* to use a test fixture

Posted by Charles Reiss <wo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2664/
-----------------------------------------------------------

(Updated 2012-02-13 22:31:04.818047)


Review request for mesos.


Changes
-------

Merged with trunk.


Summary (updated)
-------

This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.


This addresses bug MESOS-46.
    https://issues.apache.org/jira/browse/MESOS-46


Diffs (updated)
-----

  src/tests/master_tests.cpp a411ba5 

Diff: https://reviews.apache.org/r/2664/diff


Testing
-------


Thanks,

Charles