You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/11/03 17:28:55 UTC
Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No IP
Address Validation for Acquire new secondary IP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27527/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle, Jayapal Reddy, and Jessica Wang.
Bugs: CLOUDSTACK-7720
https://issues.apache.org/jira/browse/CLOUDSTACK-7720
Repository: cloudstack-git
Description
-------
Fixing Jayapal's finding (see https://issues.apache.org/jira/browse/CLOUDSTACK-7720 )
Removed required constraint from the IP address field (this is an optional field)
Diffs
-----
ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c
Diff: https://reviews.apache.org/r/27527/diff/
Testing
-------
Thanks,
Gabor Apati-Nagy
Re: Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No
IP Address Validation for Acquire new secondary IP
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27527/#review59824
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Nov. 3, 2014, 4:28 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27527/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 4:28 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jayapal Reddy, and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7720
> https://issues.apache.org/jira/browse/CLOUDSTACK-7720
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing Jayapal's finding (see https://issues.apache.org/jira/browse/CLOUDSTACK-7720 )
> Removed required constraint from the IP address field (this is an optional field)
>
>
> Diffs
> -----
>
> ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c
>
> Diff: https://reviews.apache.org/r/27527/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>