proton-j reactor branch

["Martin, Jimmy" <ja...@paypal.com.INVALID>]

Is the proton-j-reactor branch going to be merged back to master at some point or has that already happened? Please excuse me if this topic has already been discussed.

-Jimmy

Re: proton-j reactor branch

[Adrian Preston <PR...@uk.ibm.com>]

Excellent.  Thanks.

In that case, having the other bits available for end of June sounds
achievable. 

Regards
- Adrian

-----Rafael Schloming <rh...@alum.mit.edu> wrote: -----
To: "proton@qpid.apache.org" <pr...@qpid.apache.org>
From: Rafael Schloming <rh...@alum.mit.edu>
Date: 06/15/2015 08:19PM
Subject: Re: proton-j reactor branch

On Mon, Jun 15, 2015 at 3:07 PM, Adrian Preston <PR...@uk.ibm.com> wrote:

>   3) Write Jython shims do the existing Python tests can run against the
>      Proton-J reactor.
>

I have much of this done in my local checkout, I just need to patch it up a
bit and push it.

--Rafael
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: proton-j reactor branch

[Rafael Schloming <rh...@alum.mit.edu>]

On Mon, Jun 15, 2015 at 3:07 PM, Adrian Preston <PR...@uk.ibm.com> wrote:

>   3) Write Jython shims do the existing Python tests can run against the
>      Proton-J reactor.
>

I have much of this done in my local checkout, I just need to patch it up a
bit and push it.

--Rafael

Re: proton-j reactor branch

[Adrian Preston <PR...@uk.ibm.com>]

The four remaining pieces of work that I'm aware of are:
  1) Make the Reactor throw an unchecked exception if a handler throws an
     unchecked exception.
  2) Make connect asynchronous (currently its a blocking operation - so if
     the process being connected to takes a while to accept the connection
     it blocks the whole Reactor).
  3) Write Jython shims do the existing Python tests can run against the
     Proton-J reactor.
  4) General "polish".  There's a few TODO's and the interfaces don't have
     Javadoc.

If anything is missing from this list, please let me know.

As far as #1 goes - I need to do a bit of rework on a patch and (hopefully)
submit a PR tonight.

#2 Is a bit more involved - and I'd like to write a unit test that checks
that connect is done asynchronously.

The Jython shims (#3) always trip me up - so I'll probably be posting here
asking for help...

Ideally: I'm aiming to have the branch in a fit state to be merged by the
end of this month - roughly the 45th of June? ;-)
 
Regards
- Adrian

-----Rafael Schloming <rh...@alum.mit.edu> wrote: -----
To: "proton@qpid.apache.org" <pr...@qpid.apache.org>
From: Rafael Schloming <rh...@alum.mit.edu>
Date: 06/15/2015 06:58PM
Subject: Re: proton-j reactor branch

On Fri, Jun 12, 2015 at 11:16 AM, Martin, Jimmy <
jamesmartin@paypal.com.invalid> wrote:

> Is the proton-j-reactor branch going to be merged back to master at some
> point or has that already happened? Please excuse me if this topic has
> already been discussed.
>

No worries. I believe we should be able to merge it back to master pretty
soon. Certainly before the next proton release, although that raises the
excellent question of when exactly that should happen. ;-)

--Rafael
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: proton-j reactor branch

[Rafael Schloming <rh...@alum.mit.edu>]

On Fri, Jun 12, 2015 at 11:16 AM, Martin, Jimmy <
jamesmartin@paypal.com.invalid> wrote:

> Is the proton-j-reactor branch going to be merged back to master at some
> point or has that already happened? Please excuse me if this topic has
> already been discussed.
>

No worries. I believe we should be able to merge it back to master pretty
soon. Certainly before the next proton release, although that raises the
excellent question of when exactly that should happen. ;-)

--Rafael