You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 12:14:03 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1887: fix: route page Protable
iamayushdas opened a new pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Now the Route page will support all view ports and won't get messed up due to different viewports
**Related issues**
fix/resolve #1815
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887#issuecomment-838371434
cc @juzhiyuan @liuxiran @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887#issuecomment-838370789
Deploy preview for *apisix-dashboard* processing.
Building with commit 762f70fb8086621e38afb24ed0d28c07621b1c78
https://app.netlify.com/sites/apisix-dashboard/deploys/609a74ff5ba43800076677f3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887#issuecomment-838377514
should i also do this to other pages? @liuxiran
IMO: its not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887#issuecomment-838370789
Deploy preview for *apisix-dashboard* ready!
Built with commit 762f70fb8086621e38afb24ed0d28c07621b1c78
https://deploy-preview-1887--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1887: fix: route page Protable
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1887:
URL: https://github.com/apache/apisix-dashboard/pull/1887#issuecomment-838669056
> should i also do this to other pages? @liuxiran
> IMO: its not required
agree with you, it is not required for other page ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org