[GitHub] [druid] FrankChen021 commented on pull request #12407: SQL: Create millisecond precision timestamp literals.

[GitBox <gi...@apache.org>]

FrankChen021 commented on PR #12407:
URL: https://github.com/apache/druid/pull/12407#issuecomment-1105944384

   @gianm There're some failed cases and looks like they're related to the changes in this PR.
   
   ```bash
   [ERROR] org.apache.druid.sql.calcite.CalciteSelectQueryTest.testSelectCurrentTimeAndDateLosAngeles  Time elapsed: 0.064 s  <<< FAILURE!
   java.lang.AssertionError: 
   Conversion to relational algebra failed to preserve datatypes:
   validated type:
   RecordType(TIMESTAMP(0) NOT NULL CURRENT_TIMESTAMP, DATE NOT NULL CURRENT_DATE, DATE NOT NULL EXPR$2) NOT NULL
   converted type:
   RecordType(TIMESTAMP(3) NOT NULL CURRENT_TIMESTAMP, DATE NOT NULL CURRENT_DATE, DATE NOT NULL EXPR$2) NOT NULL
   rel:
   LogicalProject(CURRENT_TIMESTAMP=[1999-12-31 16:00:00:TIMESTAMP(3)], CURRENT_DATE=[1999-12-31], EXPR$2=[+(1999-12-31, 86400000:INTERVAL DAY)])
     LogicalValues(tuples=[[{ 0 }]])
   	at org.apache.calcite.sql2rel.SqlToRelConverter.checkConvertedType(SqlToRelConverter.java:458)
   	at org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:575)
   	at org.apache.calcite.prepare.PlannerImpl.rel(PlannerImpl.java:254)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org