[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1958: IGNITE-18955 Add the ability to use filters when data nodes are calculated

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #1958:
URL: https://github.com/apache/ignite-3/pull/1958#discussion_r1196287608


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -703,65 +776,23 @@ private CompletableFuture<Void> scaleDownAwaiting(int zoneId, boolean immediateS
     }
 
     /**
-     * Returns the future with data nodes of the specified zone.
+     * Returns the data nodes of the specified zone.
      *
      * @param zoneId Zone id.
      * @return Future.
      */
-    private CompletableFuture<Set<String>> getDataNodesFuture(int zoneId) {
+    private Set<String> dataNodes(int zoneId) {

Review Comment:
   Please also consider removing `getDataNodesByZoneId` in that case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org