[jira] Commented: (DERBY-2109) System privileges

["Rick Hillegas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549512 ] 

Rick Hillegas commented on DERBY-2109:
--------------------------------------

Hi Martin,

Thanks for the even better next rev of the patch. Once again, the code is beautiful. I have a couple comments:

1) EmbedConnection: It looks to me as though the CREATE DATABASE
privilege will not be enforced if the user is creating the database
from a backup copy using the "createFrom" URL attribute. I think this
is fine and the functional spec doesn't address this issue. As an
add-on effort we may want to consider if we want to restrict the
ability to create a database from a backup copy. This may be a new
database privilege ("createFrom" instead of "create") or it may be the
same privilege. In any event, the topic is worth some thought
regardless of whether we address it in 10.4.

2) SecurityUtil: There seems to be a fair amount of code shared
between checkShutdownPermission() and
checkDatabaseCreatePermission(). In a small, future patch there's an
opportunity to factor this shared code into a common routine, say,

   checkUserHasPermission( String user, Permission permission )

3) NetworkServerControlImpl:

    a) I notice at line 858 that user and
    password properties are unconditionally stuffed into a Properties
    object without checking whether they are null. In contrast, at line 1026
    these properties (in other Properties objects) are guarded by null
    checking. I think that a NullPointerException will be raised if the
    values are null. Are we sure that the username and password will
    always be non-null at line 858?

    b) processCommands(): I notice that the protocol includes
    optional username/password arguments now. I just want to confirm
    that the protocol won't do something silly if username or password
    is null or if password is specified but username isn't.





> System privileges
> -----------------
>
>                 Key: DERBY-2109
>                 URL: https://issues.apache.org/jira/browse/DERBY-2109
>             Project: Derby
>          Issue Type: New Feature
>          Components: Security
>    Affects Versions: 10.3.1.4
>            Reporter: Rick Hillegas
>            Assignee: Martin Zaun
>         Attachments: DERBY-2109-02.diff, DERBY-2109-02.stat, derby-2109-03-javadoc-see-tags.diff, DERBY-2109-04.diff, DERBY-2109-04.stat, DERBY-2109-05and06.diff, DERBY-2109-05and06.stat, DERBY-2109-07.diff, DERBY-2109-07.stat, SystemPrivilegesTestCases.html, systemPrivs.html, systemPrivs.html, systemPrivs.html, systemPrivs.html
>
>
> Add mechanisms for controlling system-level privileges in Derby. See the related email discussion at http://article.gmane.org/gmane.comp.apache.db.derby.devel/33151.
> The 10.2 GRANT/REVOKE work was a big step forward in making Derby more  secure in a client/server configuration. I'd like to plug more client/server security holes in 10.3. In particular, I'd like to focus on  authorization issues which the ANSI spec doesn't address.
> Here are the important issues which came out of the email discussion.
> Missing privileges that are above the level of a single database:
> - Create Database
> - Shutdown all databases
> - Shutdown System
> Missing privileges specific to a particular database:
> - Shutdown that Database
> - Encrypt that database
> - Upgrade database
> - Create (in that Database) Java Plugins (currently  Functions/Procedures, but someday Aggregates and VTIs)
> Note that 10.2 gave us GRANT/REVOKE control over the following  database-specific issues, via granting execute privilege to system  procedures:
> Jar Handling
> Backup Routines
> Admin Routines
> Import/Export
> Property Handling
> Check Table
> In addition, since 10.0, the privilege of connecting to a database has been controlled by two properties (derby.database.fullAccessUsers and derby.database.defaultConnectionMode) as described in the security section of the Developer's Guide (see http://db.apache.org/derby/docs/10.2/devguide/cdevcsecure865818.html).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.