You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/10 15:33:31 UTC

[GitHub] [kafka] stanislavkozlovski opened a new pull request #9155: MINOR: Ensure a single version of scala-library is used

stanislavkozlovski opened a new pull request #9155:
URL: https://github.com/apache/kafka/pull/9155


   This patch ensures we use a force resolution strategy for the scala-library dependency
   
   I've tested this locally and saw a difference in the output:
   With the change (using 2.4 and the jackson library **2.10.5**):
   ```
   ./core/build/dependant-libs-2.12.10/scala-java8-compat_2.12-0.9.0.jar
   ./core/build/dependant-libs-2.12.10/scala-collection-compat_2.12-2.1.2.jar
   ./core/build/dependant-libs-2.12.10/scala-reflect-2.12.10.jar
   ./core/build/dependant-libs-2.12.10/scala-logging_2.12-3.9.2.jar
   ./core/build/dependant-libs-2.12.10/scala-library-2.12.10.jar
   ```
   Without (using 2.4 and the jackson library **2.10.0**):
   ```
    find . -name 'scala*.jar'
   ./core/build/dependant-libs-2.12.10/scala-java8-compat_2.12-0.9.0.jar
   ./core/build/dependant-libs-2.12.10/scala-collection-compat_2.12-2.1.2.jar
   ./core/build/dependant-libs-2.12.10/scala-reflect-2.12.10.jar
   ./core/build/dependant-libs-2.12.10/scala-logging_2.12-3.9.2.jar
   ./core/build/dependant-libs-2.12.10/scala-library-2.12.12.jar
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671772900


   I fixed the commit message too before merging, so no worries. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] stanislavkozlovski commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
stanislavkozlovski commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671429610


   In 2.4 we use `def defaultScala212Version = '2.12.10'` yet it gets updated to `2.12.12` due to the jackson-module-scala library using the 2.12.12 version of scala-library in its 2.10.5 version:
   https://github.com/FasterXML/jackson-module-scala/blob/0cfeb8d27195a357887fa99f8915cfaa519aabc9/build.sbt#L8


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma merged pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9155:
URL: https://github.com/apache/kafka/pull/9155


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671562430


   2 builds passed, 1 flaky test failure for Java 8.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] stanislavkozlovski commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
stanislavkozlovski commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671714884


   I just updated the PR description to mention that both tests were using Jackson `2.10.5`. Apologies for the misleading, I must have got confused by the numerous tests I did before finding the issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671617848


   Merged to master and cherry-picked to 2.6, 2.5 and 2.4 branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671482140


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org