You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/13 15:07:24 UTC
[GitHub] [pulsar] BewareMyPower opened a new pull request #6732: Auto update
topic partitions for C++ client
BewareMyPower opened a new pull request #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
We need to increase producers or consumers when partitions updated.
Java client has implemented this feature, see [#3513](https://github.com/apache/pulsar/pull/3513). This PR trys to implement the same feature in C++ client.
### Modifications
- Add a `boost::asio::deadline_timer` to `PartitionedConsumerImpl` and `PartitionedProducerImpl` to register lookup task to detect partitions changes periodly;
- Add an `unsigned int` configuration parameter to indicate the period seconds of detecting partitions change (default: 60 seconds);
- Unlock the `mutex_` in `PartitionedConsumerImpl::receive` after `state_` were checked.
> Explain: When new consumers are created, `handleSinglePartitionConsumerCreated` will be called finally, which tried to lock the `mutex_`. It may happen that `receive` acquire the lock again and again so that `handleSinglePartitionConsumerCreated`
are blocked in `lock.lock()` for a long time.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Run `PartitionsUpdateTest` test suite after the cmake build.
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614758449
> @BewareMyPower thanks for the great work. Seems it is not normal for the cpp tests failure.
> Could the tests get success in your local env?
Yeah. The test also passed in github action, you can see CI of commit 89ba471.
cpp-tests > run-tests (line 136)
```
[98/163] PartitionsUpdateTest.testPartitionsUpdate (13748 ms)
```
The strange thing is that the 163 tests cannot be completed, I've seen at most 141 tests completed, and the number may also be 121. The current test may be 98:
```
Thu, 16 Apr 2020 16:19:38 GMT
[96/163] BasicEndToEndTest.testPatternEmptyUnsubscribe (37 ms)
Thu, 16 Apr 2020 16:19:38 GMT
[97/163] BasicEndToEndTest.testpatternMultiTopicsHttpConsumerPubSub (2493 ms)
Thu, 16 Apr 2020 16:19:38 GMT
[98/163] PartitionsUpdateTest.testPartitionsUpdate (13718 ms)
```
I guessed after 90 minutes (2 hours reached), the completes tests number will still be 90.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615471764
/pulsarbot run unit-test-flaky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower removed a comment on issue #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615465414
/pulsarbot run unit-test-flaky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #6732:
Auto update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#discussion_r409680606
##########
File path: pulsar-client-cpp/lib/PartitionedConsumerImpl.cc
##########
@@ -162,14 +174,17 @@ void PartitionedConsumerImpl::handleUnsubscribeAsync(Result result, unsigned int
callback(ResultUnknownError);
return;
}
- assert(unsubscribedSoFar_ <= numPartitions_);
- assert(consumerIndex <= numPartitions_);
+ Lock consumersLock(consumersMutex_);
+ const auto numPartitions = numPartitions_;
Review comment:
I'll change soon, here I should've called method like `getNumPartitionsWithLock()` (like I did in `PartitionedConsumerImpl`.
Because `producers_`/`consumers_` may be modified in timer's callback, the code that accessed `producers_`/`consumers_` and some other members (see comments in headers) should be protected by lock()/unlock(), except in `start()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615458751
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614208833
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614443639
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614576399
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615834751
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower removed a comment on issue #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615471764
/pulsarbot run unit-test-flaky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-616029638
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615537814
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower removed a comment on issue #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614615326
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614407545
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on a change in pull request #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#discussion_r409658821
##########
File path: pulsar-client-cpp/lib/PartitionedConsumerImpl.cc
##########
@@ -162,14 +174,17 @@ void PartitionedConsumerImpl::handleUnsubscribeAsync(Result result, unsigned int
callback(ResultUnknownError);
return;
}
- assert(unsubscribedSoFar_ <= numPartitions_);
- assert(consumerIndex <= numPartitions_);
+ Lock consumersLock(consumersMutex_);
+ const auto numPartitions = numPartitions_;
Review comment:
Could this change be avoid? Seems brings in lot of un-needed changes, also a little confusing to made `numPartitions_` and `numPartitions` mix-used together in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615160135
> @BewareMyPower thanks for the great work. Seems it is not normal for the cpp tests failure.
> Could the tests get success in your local env?
Now I've found where the problem is. The tests stuck at the loop in `TEST(BasicEndToEndTest, testPartitionTopicUnAckedMessageTimeout)`:
```c++
while (true) {
// maximum wait time
ASSERT_LE(timeWaited, unAckedMessagesTimeoutMs * 3);
if (messagesReceived >= 10 * 2) { // **Problem**: Never reached here
break;
}
std::this_thread::sleep_for(std::chrono::milliseconds(500));
timeWaited += 500;
}
```
It seems that `MessageListener` doesn't work after my commits. I will try to solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615841532
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower removed a comment on issue #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615451217
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615451217
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615864539
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615671729
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614735742
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615465414
/pulsarbot run unit-test-flaky
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614615326
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615853642
/pulsarbot run process
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615882025
/pulsarbot run process
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615476962
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614501567
/pulsarbot run unit-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614375144
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615895321
Hi, @codelipenghui @merlimat @jiazhai @sijie , could you help me with the failure of unit tests?
I've only changed files under `pulsar-client-cpp` directory, but there're some unrelated tests that can't pass:
- Integration - Process / process
- Unit - Adaptors / unit-tests
- Unit - Broker Auth SASL / unit-tests
- Unit - Flaky / unit-test-flaky
- Unit - Proxy / unit-tests
- Unit / unit-tests
They all failed with `No space left on device`. It seems like Github Actions' problem.
Failure message of `Integration - Process / process`:
> [ERROR] Error processing tar file(exit status 1): write /pulsar/connectors/pulsar-io-redis-2.6.0-SNAPSHOT.nar: no space left on device
> [ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-all-docker-image: Could not build image: Error processing tar file(exit status 1): write /pulsar/connectors/pulsar-io-redis-2.6.0-SNAPSHOT.nar: no space left on device -> [Help 1]
The other tests:
> [ERROR] Failed to execute goal on project bc_2_0_1: Could not resolve dependencies for project org.apache.pulsar.tests:bc_2_0_1:jar:2.6.0-SNAPSHOT: Could not transfer artifact org.apache.pulsar:pulsar-client:jar:2.0.1-incubating from/to central (https://repo1.maven.org/maven2): GET request of: org/apache/pulsar/pulsar-client/2.0.1-incubating/pulsar-client-2.0.1-incubating.jar from central failed: No space left on device -> [Help 1]
I tried to rollback to the older commit that has passed these tests before, or run failure checks again, but the error still happens. How should I deal with it? Should I close this PR and open a new PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614739869
@BewareMyPower thanks for the great work. Seems it is not normal for the cpp tests failure.
Could the tests get success in your local env?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower removed a comment on issue #6732: Auto
update topic partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower removed a comment on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615458751
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-615440233
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] BewareMyPower commented on issue #6732: Auto update topic
partitions for C++ client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #6732: Auto update topic partitions for C++ client
URL: https://github.com/apache/pulsar/pull/6732#issuecomment-614636618
/pulsarbot run cpp-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services