You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2012/03/29 21:03:37 UTC

android commit: Minor tweaks to DroidGap, allows for the ChromeClient and ViewClient to be overridden

Updated Branches:
  refs/heads/CordovaWebView b793fbfc2 -> 49b50ce66


Minor tweaks to DroidGap, allows for the ChromeClient and ViewClient to be overridden


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/49b50ce6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/49b50ce6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/49b50ce6

Branch: refs/heads/CordovaWebView
Commit: 49b50ce66ca9c22a6369cdebd0151a8a7a88f0ef
Parents: b793fbf
Author: Joe Bowser <bo...@apache.org>
Authored: Thu Mar 29 12:03:20 2012 -0700
Committer: Joe Bowser <bo...@apache.org>
Committed: Thu Mar 29 12:03:20 2012 -0700

----------------------------------------------------------------------
 .../src/org/apache/cordova/CordovaWebView.java     |    6 ++----
 framework/src/org/apache/cordova/DroidGap.java     |    1 +
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/49b50ce6/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index aaa11ed..461bbe4 100644
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -33,13 +33,11 @@ public class CordovaWebView extends WebView {
   
   /** Actvities and other important classes **/
   private Context mCtx;
-  private CordovaWebViewClient viewClient;
-  private CordovaChromeClient chromeClient;
 
   public CordovaWebView(Context context) {
     super(context);
     mCtx = context;
-    setup();
+    //setup();
   }
   
   public CordovaWebView(Context context, AttributeSet attrs) {
@@ -61,7 +59,7 @@ public class CordovaWebView extends WebView {
     setup();
   }
   
-  private void setup()
+  public void setup()
   {
     this.setInitialScale(0);
     this.setVerticalScrollBarEnabled(false);

http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/49b50ce6/framework/src/org/apache/cordova/DroidGap.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/DroidGap.java b/framework/src/org/apache/cordova/DroidGap.java
index 5f9e3bd..35d31b3 100755
--- a/framework/src/org/apache/cordova/DroidGap.java
+++ b/framework/src/org/apache/cordova/DroidGap.java
@@ -278,6 +278,7 @@ public class DroidGap extends Activity implements CordovaInterface {
         //      white list of allowed URLs
         //      debug setting
         this.loadConfiguration();
+        this.appView.setup();
 
         this.appView.setLayoutParams(new LinearLayout.LayoutParams(
                 ViewGroup.LayoutParams.FILL_PARENT,